starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-04-09 19:03:48 +02:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Prevent duplicate action registration in register_model_actions()

Browse Source
This commit is contained in:
Jason Novinger
2026-03-03 15:44:40 -06:00
parent 8a72b3c61c
commit a117cc7526
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
netbox/utilities/permissions.py
View File

@@ -53,7 +53,8 @@ def register_model_actions(model: type[Model], actions: list[ModelAction | str])
for action in actions: for action in actions:
if isinstance(action, str): if isinstance(action, str):
action = ModelAction(name=action) action = ModelAction(name=action)
registry['model_actions'][label].append(action) if action not in registry['model_actions'][label]:
registry['model_actions'][label].append(action)
def get_permission_for_model(model, action): def get_permission_for_model(model, action):

6
netbox/utilities/tests/test_permissions.py
View File

@@ -80,6 +80,12 @@ class RegisterModelActionsTest(TestCase):
self.assertEqual(actions[0].name, 'first') self.assertEqual(actions[0].name, 'first')
self.assertEqual(actions[1].name, 'second') self.assertEqual(actions[1].name, 'second')
def test_duplicate_registration_ignored(self):
register_model_actions(Site, [ModelAction('sync')])
register_model_actions(Site, [ModelAction('sync', help_text='Different help')])
actions = registry['model_actions']['dcim.site']
self.assertEqual(len(actions), 1)
class ObjectPermissionFormTest(TestCase): class ObjectPermissionFormTest(TestCase):