starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-04-23 09:18:49 +02:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

fix(virtualization): Hide VM Add Components dropdown without change permission

Browse Source 
Wrap the VirtualMachine "Add Components" dropdown in a
`virtualization.change_virtualmachine` permission check to match Device
behavior and prevent users without change permission from seeing
component add actions.

Fixes #21580
This commit is contained in:
Martin Hauser
2026-03-10 20:12:05 +01:00
parent f938309ed9
commit 983c98604c
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
netbox/templates/virtualization/virtualmachine/base.html
View File

@@ -16,23 +16,23 @@
{% endblock %} {% endblock %}
{% block extra_controls %} {% block extra_controls %}
{% if perms.virtualization.change_virtualmachine %}
<div class="dropdown"> <div class="dropdown">
<button id="add-components" type="button" class="btn btn-primary dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false"> <button id="add-components" type="button" class="btn btn-primary dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false">
<i class="mdi mdi-plus-thick" aria-hidden="true"></i> {% trans "Add Components" %} <i class="mdi mdi-plus-thick" aria-hidden="true"></i> {% trans "Add Components" %}
</button> </button>
<ul class="dropdown-menu" aria-labeled-by="add-components"> <ul class="dropdown-menu" aria-labeled-by="add-components">
{% if perms.virtualization.add_vminterface %} {% if perms.virtualization.add_vminterface %}
<li><a class="dropdown-item" href="{% url 'virtualization:vminterface_add' %}?virtual_machine={{ object.pk }}&return_url={% url 'virtualization:virtualmachine_interfaces' pk=object.pk %}"> <li><a class="dropdown-item" href="{% url 'virtualization:vminterface_add' %}?virtual_machine={{ object.pk }}&return_url={% url 'virtualization:virtualmachine_interfaces' pk=object.pk %}">
{% trans "Interfaces" %} {% trans "Interfaces" %}
</a></li> </a></li>
{% endif %} {% endif %}
{% if perms.virtualization.add_virtualdisk %} {% if perms.virtualization.add_virtualdisk %}
<li><a class="dropdown-item" href="{% url 'virtualization:virtualdisk_add' %}?virtual_machine={{ object.pk }}&return_url={% url 'virtualization:virtualmachine_disks' pk=object.pk %}"> <li><a class="dropdown-item" href="{% url 'virtualization:virtualdisk_add' %}?virtual_machine={{ object.pk }}&return_url={% url 'virtualization:virtualmachine_disks' pk=object.pk %}">
{% trans "Virtual Disks" %} {% trans "Virtual Disks" %}
</a></li> </a></li>
{% endif %} {% endif %}
</ul> </ul>
</div> </div>
{% endif %}
{% endblock %} {% endblock %}