From dacb7d7f6168d9be2757e3f926474d925dd11f26 Mon Sep 17 00:00:00 2001 From: Brian Tiemann Date: Wed, 18 Feb 2026 15:41:38 -0500 Subject: [PATCH 1/2] Emit deprecation warning on use of querystring template tag --- netbox/utilities/templatetags/helpers.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/netbox/utilities/templatetags/helpers.py b/netbox/utilities/templatetags/helpers.py index 19318111e..af7f13ea1 100644 --- a/netbox/utilities/templatetags/helpers.py +++ b/netbox/utilities/templatetags/helpers.py @@ -1,4 +1,5 @@ import json +import logging from typing import Dict, Any from urllib.parse import quote @@ -13,6 +14,8 @@ from utilities.forms.mixins import FORM_FIELD_LOOKUPS from utilities.views import get_viewname, get_action_url from netbox.settings import DISK_BASE_UNIT, RAM_BASE_UNIT +logger = logging.getLogger("netbox.utilities.templatetags.helpers") + __all__ = ( 'action_url', 'applied_filters', @@ -364,6 +367,10 @@ def querystring(request, **kwargs): """ Append or update the page number in a querystring. """ + logger.warning( + 'The querystring template tag is deprecated and will be removed in a future release. Use ' + 'the built-in Django querystring tag instead.', + ) querydict = request.GET.copy() for k, v in kwargs.items(): if v is not None: From 517b23b6ab95a4424c2785a205eeea6ef69db1a6 Mon Sep 17 00:00:00 2001 From: Brian Tiemann Date: Fri, 6 Mar 2026 20:44:36 -0500 Subject: [PATCH 2/2] Use warnings.warn instead of logger.warning --- netbox/utilities/templatetags/helpers.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/netbox/utilities/templatetags/helpers.py b/netbox/utilities/templatetags/helpers.py index 5a7216c54..b5f860456 100644 --- a/netbox/utilities/templatetags/helpers.py +++ b/netbox/utilities/templatetags/helpers.py @@ -1,5 +1,5 @@ import json -import logging +import warnings from typing import Any from urllib.parse import quote @@ -14,8 +14,6 @@ from utilities.forms import TableConfigForm, get_selected_values from utilities.forms.mixins import FORM_FIELD_LOOKUPS from utilities.views import get_action_url, get_viewname -logger = logging.getLogger("netbox.utilities.templatetags.helpers") - __all__ = ( 'action_url', 'applied_filters', @@ -366,9 +364,10 @@ def querystring(request, **kwargs): """ Append or update the page number in a querystring. """ - logger.warning( + warnings.warn( 'The querystring template tag is deprecated and will be removed in a future release. Use ' 'the built-in Django querystring tag instead.', + category=FutureWarning, ) querydict = request.GET.copy() for k, v in kwargs.items():