mirror of
https://github.com/netbox-community/netbox.git
synced 2026-04-10 11:23:58 +02:00
feat(ui): Add lazy loading and decoding options for ImageAttr
Introduces `load_lazy` and `decoding` parameters to `ImageAttr` for enhanced image handling. Lazy loading improves page performance, while configurable decoding options provide greater flexibility. Updates the template to conditionally include these attributes in rendered HTML. Fixes #21369
This commit is contained in:
@@ -24,11 +24,13 @@ __all__ = (
|
|||||||
|
|
||||||
PLACEHOLDER_HTML = '<span class="text-muted">—</span>'
|
PLACEHOLDER_HTML = '<span class="text-muted">—</span>'
|
||||||
|
|
||||||
|
IMAGE_DECODING_CHOICES = ('auto', 'async', 'sync')
|
||||||
|
|
||||||
#
|
#
|
||||||
# Attributes
|
# Attributes
|
||||||
#
|
#
|
||||||
|
|
||||||
|
|
||||||
class ObjectAttribute:
|
class ObjectAttribute:
|
||||||
"""
|
"""
|
||||||
Base class for representing an attribute of an object.
|
Base class for representing an attribute of an object.
|
||||||
@@ -193,9 +195,37 @@ class ColorAttr(ObjectAttribute):
|
|||||||
class ImageAttr(ObjectAttribute):
|
class ImageAttr(ObjectAttribute):
|
||||||
"""
|
"""
|
||||||
An attribute representing an image field on the model. Displays the uploaded image.
|
An attribute representing an image field on the model. Displays the uploaded image.
|
||||||
|
|
||||||
|
Parameters:
|
||||||
|
load_lazy (bool): If True, the image will be loaded lazily (default: True)
|
||||||
|
decoding (str): Image decoding option ('async', 'sync', 'auto', None)
|
||||||
"""
|
"""
|
||||||
template_name = 'ui/attrs/image.html'
|
template_name = 'ui/attrs/image.html'
|
||||||
|
|
||||||
|
def __init__(self, *args, load_lazy=True, decoding=None, **kwargs):
|
||||||
|
super().__init__(*args, **kwargs)
|
||||||
|
self.load_lazy = load_lazy
|
||||||
|
|
||||||
|
if decoding is not None and decoding not in IMAGE_DECODING_CHOICES:
|
||||||
|
raise ValueError(
|
||||||
|
_('Invalid decoding option: {decoding}! Must be one of {image_decoding_choices}').format(
|
||||||
|
decoding=decoding, image_decoding_choices=', '.join(IMAGE_DECODING_CHOICES)
|
||||||
|
)
|
||||||
|
)
|
||||||
|
|
||||||
|
# Compute default decoding:
|
||||||
|
# - lazy images: async decoding (performance-friendly hint)
|
||||||
|
# - non-lazy images: omit decoding (browser default/auto)
|
||||||
|
if decoding is None and load_lazy:
|
||||||
|
decoding = 'async'
|
||||||
|
self.decoding = decoding
|
||||||
|
|
||||||
|
def get_context(self, obj, context):
|
||||||
|
return {
|
||||||
|
'decoding': self.decoding,
|
||||||
|
'load_lazy': self.load_lazy,
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
class RelatedObjectAttr(ObjectAttribute):
|
class RelatedObjectAttr(ObjectAttribute):
|
||||||
"""
|
"""
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
<a href="{{ value.url }}">
|
<a href="{{ value.url }}">
|
||||||
<img src="{{ value.url }}" alt="{{ value.name }}" class="img-fluid" />
|
<img src="{{ value.url }}" alt="{{ value.name }}" class="img-fluid" {% if load_lazy %}loading="lazy" {% endif %} {% if decoding %}decoding="{{ decoding }}" {% endif %}/>
|
||||||
</a>
|
</a>
|
||||||
|
|||||||
Reference in New Issue
Block a user