starred/minne
1
0
Fork 0
mirror of https://github.com/perstarkse/minne.git synced 2026-06-25 11:26:17 +02:00
Code Issues Packages Projects Releases 10 Wiki Activity

fix: replaced several instances if cloning, reduced allocations

Browse Source
This commit is contained in:
Per Stark
2026-06-06 19:45:18 +02:00
parent ac0d34bfbd
commit 60cf63292a
12 changed files with 254 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/src/utils/embedding.rs
+5 -5
View File
@@ -372,17 +372,17 @@ impl EmbeddingProvider {
///
/// Returns [`EmbeddingError`] if the backend API call fails or returns no embedding data.
/// Returns an empty `Vec` when `texts` is empty.
pub async fn embed_batch(&self, texts: Vec<String>) -> Result<Vec<Vec<f32>>, EmbeddingError> {
pub async fn embed_batch(&self, texts: &[String]) -> Result<Vec<Vec<f32>>, EmbeddingError> {
match &self.inner {
EmbeddingInner::Hashed { dimension } => Ok(texts
.into_iter()
.map(|text| hashed_embedding(&text, *dimension))
.iter()
.map(|text| hashed_embedding(text, *dimension))
.collect()),
EmbeddingInner::FastEmbed { pool, .. } => {
if texts.is_empty() {
return Ok(Vec::new());
}
run_fastembed(pool, texts).await
run_fastembed(pool, texts.to_vec()).await
}
EmbeddingInner::OpenAI {
client,
@@ -395,7 +395,7 @@ impl EmbeddingProvider {
let request = CreateEmbeddingRequestArgs::default()
.model(model.clone())
.input(texts)
.input(texts.to_vec())
.dimensions(*dimensions)
.build()?;