starred/minne
1
0
Fork 0
mirror of https://github.com/perstarkse/minne.git synced 2026-05-30 03:10:45 +02:00
Code Issues Packages Projects Releases 10 Wiki Activity

clippy: evaluations crate

Browse Source
This commit is contained in:
Per Stark
2026-05-26 20:07:51 +02:00
parent b4383bb227
commit 041d9bd81f
16 changed files with 88 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files
evaluations/src/pipeline/stages/finalize.rs
+3 -3
View File
@@ -38,9 +38,9 @@ pub(crate) async fn finalize(
}
info!(
total_cases = ctx.summary.as_ref().map(|s| s.total_cases).unwrap_or(0),
correct = ctx.summary.as_ref().map(|s| s.correct).unwrap_or(0),
precision = ctx.summary.as_ref().map(|s| s.precision).unwrap_or(0.0),
total_cases = ctx.summary.as_ref().map_or(0, |s| s.total_cases),
correct = ctx.summary.as_ref().map_or(0, |s| s.correct),
precision = ctx.summary.as_ref().map_or(0.0, |s| s.precision),
dataset = ctx.dataset().metadata.id.as_str(),
"Evaluation complete"
);
evaluations/src/pipeline/stages/prepare_corpus.rs
+4 -5
View File
@@ -82,12 +82,11 @@ pub(crate) async fn prepare_corpus(
return machine
.prepare_corpus()
.map_err(|(_, guard)| map_guard_error("prepare_corpus", guard));
} else {
info!(
cache = %base_dir.display(),
"Namespace reusable but cached manifest missing; regenerating corpus"
);
}
info!(
cache = %base_dir.display(),
"Namespace reusable but cached manifest missing; regenerating corpus"
);
}
}
evaluations/src/pipeline/stages/run_queries.rs
+5 -5
View File
@@ -179,7 +179,7 @@ pub(crate) async fn run_queries(
debug!(question_id = %question_id, "Evaluating query");
let query_embedding =
embedding_provider.embed(&question).await.with_context(|| {
format!("generating embedding for question {}", question_id)
format!("generating embedding for question {question_id}")
})?;
let reranker = match rerank_pool.as_ref() {
Some(pool) => pool.checkout().await,
@@ -201,7 +201,7 @@ pub(crate) async fn run_queries(
query_embedding,
)
.await
.with_context(|| format!("running pipeline for question {}", question_id))?;
.with_context(|| format!("running pipeline for question {question_id}"))?;
(outcome.results, outcome.diagnostics, outcome.stage_timings)
} else {
let outcome = pipeline::run_pipeline_with_embedding_with_metrics(
@@ -209,7 +209,7 @@ pub(crate) async fn run_queries(
query_embedding,
)
.await
.with_context(|| format!("running pipeline for question {}", question_id))?;
.with_context(|| format!("running pipeline for question {question_id}"))?;
(outcome.results, None, outcome.stage_timings)
};
let query_latency = query_start.elapsed().as_millis();
@@ -220,7 +220,7 @@ pub(crate) async fn run_queries(
let answers_lower: Vec<String> =
answers.iter().map(|ans| ans.to_ascii_lowercase()).collect();
let expected_chunk_ids_set: HashSet<&str> =
expected_chunk_ids.iter().map(|id| id.as_str()).collect();
expected_chunk_ids.iter().map(std::string::String::as_str).collect();
let chunk_id_required = has_verified_chunks;
let mut entity_hit = false;
let mut chunk_text_hit = false;
@@ -408,7 +408,7 @@ fn calculate_ndcg(retrieved: &[RetrievedSummary], k: usize) -> f64 {
let mut idcg = 0.0;
for i in 0..relevant_count {
let rel = 1.0;
idcg += rel / (i as f64 + 2.0).log2();
idcg += rel / (f64::from(i) + 2.0).log2();
}
if idcg == 0.0 {