starred/linsa
1
0
Fork 0
mirror of https://github.com/linsa-io/linsa.git synced 2026-01-11 20:00:23 +01:00
Code Issues 2 Packages Projects Releases Wiki Activity

[PR #168] [MERGED] feat(shortcut): Keyboard Navigation #93

New Issue
Closed
opened 2025-12-29 18:28:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:28:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/linsa-io/linsa/pull/168
Author: @Aslam97
Created: 9/18/2024
Status: ✅ Merged
Merged: 9/19/2024
Merged by: @Aslam97

Base: main ← Head: feat/shortcut

📝 Commits (10+)

  • 776e0a5 chore: remove sliding menu
  • 8ade101 feat(ui): sheet
  • 9b1b17a feat: shortcut component
  • 2cdb497 chore: register new shortcut component to layout
  • 1cfbe3d fix: react attr naming
  • d28eff8 fix: set default to false for shortcut
  • 91b02ab feat(store): keydown-manager
  • 1f3e379 feat(hooks): keyboard manager
  • 01a2c7b chore: use util from base for la-editor
  • 433e8b3 chore: use util from base for minimal-tiptap-editor

📊 Changes

23 files changed (+682 additions, -511 deletions)

View changed files

📝 web/app/(pages)/layout.tsx (+9 -3)
➕ web/components/custom/Shortcut/shortcut.tsx (+155 -0)
📝 web/components/custom/command-palette/command-palette.tsx (+7 -9)
📝 web/components/custom/discordIcon.tsx (+7 -7)
➕ web/components/custom/global-keydown-handler.tsx (+63 -0)
📝 web/components/custom/sidebar/partial/profile-section.tsx (+114 -83)
📝 web/components/la-editor/components/ui/shortcut.tsx (+2 -2)
📝 web/components/la-editor/extensions/slash-command/menu-list.tsx (+6 -2)
📝 web/components/la-editor/lib/utils/index.ts (+0 -2)
➖ web/components/la-editor/lib/utils/keyboard.ts (+0 -25)
➖ web/components/la-editor/lib/utils/platform.ts (+0 -46)
📝 web/components/minimal-tiptap/components/shortcut-key.tsx (+24 -24)
📝 web/components/minimal-tiptap/components/toolbar-section.tsx (+98 -98)
📝 web/components/minimal-tiptap/utils.ts (+10 -77)
📝 web/components/routes/link/bottom-bar.tsx (+14 -27)
📝 web/components/routes/topics/detail/TopicDetailRoute.tsx (+1 -0)
➕ web/components/ui/sheet.tsx (+109 -0)
➖ web/components/ui/sliding-menu.tsx (+0 -82)
➕ web/hooks/use-keyboard-manager.ts (+38 -0)
➕ web/hooks/use-keydown-listener.ts (+21 -0)

...and 3 more files

📄 Description

New Features

  • Added new shortcut UI in the profile section dropdown
  • Implemented "disable keydown" feature to prevent keydown events when certain components (e.g., dialogs, dropdowns, popovers) are rendered
  • Introduced new sheet component

Enhancements

  • Added keyboard shortcut for user sign-out
  • Added keyboard shortcuts for navigating between pages

Removals

  • Removed old shortcut UI (previously only available on link URLs)

Notes

  • The new shortcut UI replaces the old version and is now more accessible
  • The "disable keydown" feature improves user experience by preventing unintended actions

Learn Anything · 5 47pm · 09-19

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/linsa-io/linsa/pull/168 **Author:** [@Aslam97](https://github.com/Aslam97) **Created:** 9/18/2024 **Status:** ✅ Merged **Merged:** 9/19/2024 **Merged by:** [@Aslam97](https://github.com/Aslam97) **Base:** `main` ← **Head:** `feat/shortcut` --- ### 📝 Commits (10+) - [`776e0a5`](https://github.com/linsa-io/linsa/commit/776e0a5e0062494d190df919437a6d8013491e4d) chore: remove sliding menu - [`8ade101`](https://github.com/linsa-io/linsa/commit/8ade1011e04753cc5efec56ef64ca98c7f05c42e) feat(ui): sheet - [`9b1b17a`](https://github.com/linsa-io/linsa/commit/9b1b17adf35dd919649c71cdb592dc9ffd95fb03) feat: shortcut component - [`2cdb497`](https://github.com/linsa-io/linsa/commit/2cdb49798827b0843b0a1b0476302306ef2f6e58) chore: register new shortcut component to layout - [`1cfbe3d`](https://github.com/linsa-io/linsa/commit/1cfbe3d547b74769c43fb5708f15edecbc54842a) fix: react attr naming - [`d28eff8`](https://github.com/linsa-io/linsa/commit/d28eff8d24e2b5726e55d53a2721bbe541032ff4) fix: set default to false for shortcut - [`91b02ab`](https://github.com/linsa-io/linsa/commit/91b02ab0d4699179c25a186ec36bccb2d0a9ac8b) feat(store): keydown-manager - [`1f3e379`](https://github.com/linsa-io/linsa/commit/1f3e37955d349eceb532c9de63a6c4e3c78cf33e) feat(hooks): keyboard manager - [`01a2c7b`](https://github.com/linsa-io/linsa/commit/01a2c7b38607655ba0f5078b220137a7274a47ee) chore: use util from base for la-editor - [`433e8b3`](https://github.com/linsa-io/linsa/commit/433e8b3ff206299e5a270a86230a062c5672b6c1) chore: use util from base for minimal-tiptap-editor ### 📊 Changes **23 files changed** (+682 additions, -511 deletions) <details> <summary>View changed files</summary> 📝 `web/app/(pages)/layout.tsx` (+9 -3) ➕ `web/components/custom/Shortcut/shortcut.tsx` (+155 -0) 📝 `web/components/custom/command-palette/command-palette.tsx` (+7 -9) 📝 `web/components/custom/discordIcon.tsx` (+7 -7) ➕ `web/components/custom/global-keydown-handler.tsx` (+63 -0) 📝 `web/components/custom/sidebar/partial/profile-section.tsx` (+114 -83) 📝 `web/components/la-editor/components/ui/shortcut.tsx` (+2 -2) 📝 `web/components/la-editor/extensions/slash-command/menu-list.tsx` (+6 -2) 📝 `web/components/la-editor/lib/utils/index.ts` (+0 -2) ➖ `web/components/la-editor/lib/utils/keyboard.ts` (+0 -25) ➖ `web/components/la-editor/lib/utils/platform.ts` (+0 -46) 📝 `web/components/minimal-tiptap/components/shortcut-key.tsx` (+24 -24) 📝 `web/components/minimal-tiptap/components/toolbar-section.tsx` (+98 -98) 📝 `web/components/minimal-tiptap/utils.ts` (+10 -77) 📝 `web/components/routes/link/bottom-bar.tsx` (+14 -27) 📝 `web/components/routes/topics/detail/TopicDetailRoute.tsx` (+1 -0) ➕ `web/components/ui/sheet.tsx` (+109 -0) ➖ `web/components/ui/sliding-menu.tsx` (+0 -82) ➕ `web/hooks/use-keyboard-manager.ts` (+38 -0) ➕ `web/hooks/use-keydown-listener.ts` (+21 -0) _...and 3 more files_ </details> ### 📄 Description ### New Features - Added new shortcut UI in the profile section dropdown - Implemented "disable keydown" feature to prevent keydown events when certain components (e.g., dialogs, dropdowns, popovers) are rendered - Introduced new sheet component ### Enhancements - Added keyboard shortcut for user sign-out - Added keyboard shortcuts for navigating between pages ### Removals - Removed old shortcut UI (previously only available on link URLs) ### Notes - The new shortcut UI replaces the old version and is now more accessible - The "disable keydown" feature improves user experience by preventing unintended actions ![Learn Anything · 5 47pm · 09-19](https://github.com/user-attachments/assets/0c409203-c944-4eb1-bee4-3e5105e762a6) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 18:28:17 +01:00
adam closed this issue 2025-12-29 18:28:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/linsa#93
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?