[PR #166] [MERGED] fix(page): Add item scroll, fix display issues, refactor nav, and improve perf #85

Closed
opened 2025-12-29 18:28:13 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/linsa-io/linsa/pull/166
Author: @Aslam97
Created: 9/17/2024
Status: Merged
Merged: 9/19/2024
Merged by: @Aslam97

Base: mainHead: fix/page


📝 Commits (7)

  • 31245eb feat: add item scroll to active
  • bb8cf0e fix: reset enterkey and scroll to view
  • c24d158 fix: link item displayName
  • 5b64876 refactor: remove keyboard page nav
  • 8f6efcd chore: fix scrolling, perf, keys, highlight active item etc
  • eb55bd6 chore: use new hook for create a page
  • 2b5570c chore: disabled auto delete page

📊 Changes

13 files changed (+307 additions, -336 deletions)

View changed files

📝 web/components/custom/command-palette/hooks/use-command-actions.ts (+6 -13)
📝 web/components/custom/sidebar/partial/page-section.tsx (+4 -11)
📝 web/components/routes/link/LinkRoute.tsx (+7 -1)
📝 web/components/routes/link/header.tsx (+1 -1)
📝 web/components/routes/link/list.tsx (+4 -6)
📝 web/components/routes/link/partials/link-item.tsx (+123 -119)
📝 web/components/routes/page/detail/PageDetailRoute.tsx (+26 -27)
📝 web/components/routes/page/header.tsx (+37 -33)
web/components/routes/page/hooks/use-keyboard-navigation.ts (+0 -69)
📝 web/components/routes/page/hooks/use-page-actions.ts (+10 -1)
📝 web/components/routes/page/list.tsx (+52 -39)
📝 web/components/routes/page/partials/page-item.tsx (+7 -16)
web/hooks/use-active-item-scroll.ts (+30 -0)

📄 Description

Features

  • Added item scroll to active

Fixes

  • Reset enterkey and scroll to view
  • Linked item displayName

Refactor

  • Removed keyboard page nav

Chores

  • Fixed scrolling, performance, keys, highlight active item, etc.
  • Implemented new hook for creating a page
  • Disabled auto delete page

Deployment

  • Deployed to Preview environment

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/linsa-io/linsa/pull/166 **Author:** [@Aslam97](https://github.com/Aslam97) **Created:** 9/17/2024 **Status:** ✅ Merged **Merged:** 9/19/2024 **Merged by:** [@Aslam97](https://github.com/Aslam97) **Base:** `main` ← **Head:** `fix/page` --- ### 📝 Commits (7) - [`31245eb`](https://github.com/linsa-io/linsa/commit/31245eba9ba20494fd99994a8a1298d7e28cf2f7) feat: add item scroll to active - [`bb8cf0e`](https://github.com/linsa-io/linsa/commit/bb8cf0ecc07954c63de6545287a37e6d4111cd20) fix: reset enterkey and scroll to view - [`c24d158`](https://github.com/linsa-io/linsa/commit/c24d158790020d85988b0cb5601e65a688968c5c) fix: link item displayName - [`5b64876`](https://github.com/linsa-io/linsa/commit/5b64876e72f261e2f9f33a80c253ff82ed4b04de) refactor: remove keyboard page nav - [`8f6efcd`](https://github.com/linsa-io/linsa/commit/8f6efcd81cde564ae3e2d0a710cb72ea131eacf4) chore: fix scrolling, perf, keys, highlight active item etc - [`eb55bd6`](https://github.com/linsa-io/linsa/commit/eb55bd633458dd4b3b4010170a05ac770c8a165f) chore: use new hook for create a page - [`2b5570c`](https://github.com/linsa-io/linsa/commit/2b5570c87ac2384d853a6908f35ca9d4b37f6d89) chore: disabled auto delete page ### 📊 Changes **13 files changed** (+307 additions, -336 deletions) <details> <summary>View changed files</summary> 📝 `web/components/custom/command-palette/hooks/use-command-actions.ts` (+6 -13) 📝 `web/components/custom/sidebar/partial/page-section.tsx` (+4 -11) 📝 `web/components/routes/link/LinkRoute.tsx` (+7 -1) 📝 `web/components/routes/link/header.tsx` (+1 -1) 📝 `web/components/routes/link/list.tsx` (+4 -6) 📝 `web/components/routes/link/partials/link-item.tsx` (+123 -119) 📝 `web/components/routes/page/detail/PageDetailRoute.tsx` (+26 -27) 📝 `web/components/routes/page/header.tsx` (+37 -33) ➖ `web/components/routes/page/hooks/use-keyboard-navigation.ts` (+0 -69) 📝 `web/components/routes/page/hooks/use-page-actions.ts` (+10 -1) 📝 `web/components/routes/page/list.tsx` (+52 -39) 📝 `web/components/routes/page/partials/page-item.tsx` (+7 -16) ➕ `web/hooks/use-active-item-scroll.ts` (+30 -0) </details> ### 📄 Description ## Features - Added item scroll to active ## Fixes - Reset enterkey and scroll to view - Linked item displayName ## Refactor - Removed keyboard page nav ## Chores - Fixed scrolling, performance, keys, highlight active item, etc. - Implemented new hook for creating a page - Disabled auto delete page ## Deployment - Deployed to Preview environment --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 18:28:13 +01:00
adam closed this issue 2025-12-29 18:28:15 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/linsa#85