starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #556] [MERGED] feat(cli): add cycle-layout command #985

New Issue
Closed
opened 2026-01-05 14:53:38 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:53:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/556
Author: @krshrimali
Created: 10/8/2023
Status: ✅ Merged
Merged: 10/27/2023
Merged by: @LGUG2Z

Base: master ← Head: kush/toggle_layout

📝 Commits (7)

  • c311db8 Command to ToggleLayout
  • e9353d5 Just improve logic of figuring out next layout
  • aad88aa Addr review: rename to "Cycle" instead of toggle, and add a small comment
  • b333bed As per review comments, implement cycle method on DefaultLayout
  • 1a2cad6 I forgot to remove this, my bad
  • bbdcd35 feat(cli): fixups for cycle-layout cmd
  • 4fa8108 Update komorebic/src/main.rs

📊 Changes

6 files changed (+62 additions, -0 deletions)

View changed files

📝 komorebi-core/src/default_layout.rs (+25 -0)
📝 komorebi-core/src/lib.rs (+1 -0)
📝 komorebi/src/process_command.rs (+2 -0)
📝 komorebi/src/window_manager.rs (+23 -0)
📝 komorebic.lib.ahk (+4 -0)
📝 komorebic/src/main.rs (+7 -0)

📄 Description

Resolves issue: https://github.com/LGUG2Z/komorebi/issues/555#issuecomment-1751916248.

This PR:

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/556 **Author:** [@krshrimali](https://github.com/krshrimali) **Created:** 10/8/2023 **Status:** ✅ Merged **Merged:** 10/27/2023 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `kush/toggle_layout` --- ### 📝 Commits (7) - [`c311db8`](https://github.com/LGUG2Z/komorebi/commit/c311db8533ed37499241720f045036840d97e7ad) Command to ToggleLayout - [`e9353d5`](https://github.com/LGUG2Z/komorebi/commit/e9353d537491b7d89fe7bd8b0347362ca56de7e5) Just improve logic of figuring out next layout - [`aad88aa`](https://github.com/LGUG2Z/komorebi/commit/aad88aa90571c150b15143013e4fb8017a12d6fb) Addr review: rename to "Cycle" instead of toggle, and add a small comment - [`b333bed`](https://github.com/LGUG2Z/komorebi/commit/b333bed005f09068997333f1551192c07f6ce82f) As per review comments, implement cycle method on DefaultLayout - [`1a2cad6`](https://github.com/LGUG2Z/komorebi/commit/1a2cad65cb6a7e3047337dcaa15217a1cde675ec) I forgot to remove this, my bad - [`bbdcd35`](https://github.com/LGUG2Z/komorebi/commit/bbdcd3584de20e30ae1467691ccafebf8c3652a8) feat(cli): fixups for cycle-layout cmd - [`4fa8108`](https://github.com/LGUG2Z/komorebi/commit/4fa8108f8c74eaf2d02ab840ad9a5fae361afffb) Update komorebic/src/main.rs ### 📊 Changes **6 files changed** (+62 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-core/src/default_layout.rs` (+25 -0) 📝 `komorebi-core/src/lib.rs` (+1 -0) 📝 `komorebi/src/process_command.rs` (+2 -0) 📝 `komorebi/src/window_manager.rs` (+23 -0) 📝 `komorebic.lib.ahk` (+4 -0) 📝 `komorebic/src/main.rs` (+7 -0) </details> ### 📄 Description Resolves issue: https://github.com/LGUG2Z/komorebi/issues/555#issuecomment-1751916248. This PR: - Adds command to support `Cycle(CycleDirection)` using `cycle_next` and `cycle_previous` on DefaultLayout - As per discussion, this PR will only support cycling layouts for DefaultLayout and not for CustomLayout. https://github.com/LGUG2Z/komorebi/pull/556#discussion_r1349709174 <- Discussion link --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:53:38 +01:00
adam closed this issue 2026-01-05 14:53:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#985
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?