starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #545] [MERGED] feat(wm): ultrawide layout resizing #980

New Issue
Closed
opened 2026-01-05 14:53:37 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:53:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/545
Author: @NotLebedev
Created: 9/25/2023
Status: ✅ Merged
Merged: 10/7/2023
Merged by: @LGUG2Z

Base: master ← Head: ultrawide-resize

📝 Commits (5)

  • 51e45c4 Allow different resize constraints for layouts
  • 9daddeb Add resize constraints for UltrawideVerticalStack layout
  • 0dd00eb feat(wm): Use resize_dimensions in calculate for ultrawide layout
  • 2f9c908 feat(wm): Enable ultrawide layout in DefaultLayout::resize
  • 9bf7d0f feat(wm): refactor ultrawide resize calculation

📊 Changes

3 files changed (+265 additions, -80 deletions)

View changed files

📝 komorebi-core/src/arrangement.rs (+188 -79)
📝 komorebi-core/src/default_layout.rs (+1 -1)
📝 komorebi/src/workspace.rs (+76 -0)

📄 Description

Currently only BSP layout and primary container of custom layouts can be resized. BSP layout is not very good for ultrawide screens and resizing only primary container is limiting. This PR adds resizing for ultrawide-vertical-stack layout and refactors some code related to resize calculation.

  1. Workspace::enforce_resize_constraints can now enforce different constraints for different layouts and for those layouts that can not be resized resize_dimensions is explicitly set to 0 (previously everything was constrained as for BSP)
  2. New function for constraining resizing of ultrawide-vertical-stack layout, which can be resized differently then BSP
  3. Layout calculation for ultrawide-vertical-stack now apply resize_dimensions via new function calculate_ultrawide_adjustment. Base layout is kept the same, resizing changes are applied on top

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/545 **Author:** [@NotLebedev](https://github.com/NotLebedev) **Created:** 9/25/2023 **Status:** ✅ Merged **Merged:** 10/7/2023 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `ultrawide-resize` --- ### 📝 Commits (5) - [`51e45c4`](https://github.com/LGUG2Z/komorebi/commit/51e45c4b22afc60567e255ccf7c9278f5f76465a) Allow different resize constraints for layouts - [`9daddeb`](https://github.com/LGUG2Z/komorebi/commit/9daddebb3315913e66840ea591d9197982d44ea1) Add resize constraints for UltrawideVerticalStack layout - [`0dd00eb`](https://github.com/LGUG2Z/komorebi/commit/0dd00eb4817a6875a35cef787d0e956abe46c079) feat(wm): Use resize_dimensions in calculate for ultrawide layout - [`2f9c908`](https://github.com/LGUG2Z/komorebi/commit/2f9c9088b9e84fb06c5afc35239507815996b1d8) feat(wm): Enable ultrawide layout in DefaultLayout::resize - [`9bf7d0f`](https://github.com/LGUG2Z/komorebi/commit/9bf7d0f7ca2d31e311c83d9cbd393b09ee88b54b) feat(wm): refactor ultrawide resize calculation ### 📊 Changes **3 files changed** (+265 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-core/src/arrangement.rs` (+188 -79) 📝 `komorebi-core/src/default_layout.rs` (+1 -1) 📝 `komorebi/src/workspace.rs` (+76 -0) </details> ### 📄 Description Currently only BSP layout and primary container of custom layouts can be resized. BSP layout is not very good for ultrawide screens and resizing only primary container is limiting. This PR adds resizing for `ultrawide-vertical-stack` layout and refactors some code related to resize calculation. 1. `Workspace::enforce_resize_constraints` can now enforce different constraints for different layouts and for those layouts that can not be resized `resize_dimensions` is explicitly set to 0 (previously everything was constrained as for BSP) 2. New function for constraining resizing of `ultrawide-vertical-stack` layout, which can be resized differently then BSP 3. Layout calculation for `ultrawide-vertical-stack` now apply `resize_dimensions` via new function `calculate_ultrawide_adjustment`. Base layout is kept the same, resizing changes are applied on top --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:53:37 +01:00
adam closed this issue 2026-01-05 14:53:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#980
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?