starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #492] [MERGED] fix: Allowed support for spaces in config path #952

New Issue
Closed
opened 2026-01-05 14:53:32 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:53:32 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/492
Author: @JohnnyTNguyen
Created: 7/14/2023
Status: ✅ Merged
Merged: 7/14/2023
Merged by: @LGUG2Z

Base: master ← Head: master

📝 Commits (1)

  • 799739e Allowed support for spaces in config path

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 komorebic/src/main.rs (+1 -1)

📄 Description

fix: If the provided configuration path unfortunately includes a space (like C:/Users/FirstName LastName/...), then komorebi fails to find the configuration file as it gets '--config=C:/Users/FirstName LastName/...' from komorebic which looks like only C:/User/FirstName. Wrapping the path in quotes helps komorebi to find the configuration file.

P.S. I'm new to contributing, so if this is improper formatting, or if there's a smart way to supply the config path already without needing this change, I'm open to learning. Thanks!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/492 **Author:** [@JohnnyTNguyen](https://github.com/JohnnyTNguyen) **Created:** 7/14/2023 **Status:** ✅ Merged **Merged:** 7/14/2023 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`799739e`](https://github.com/LGUG2Z/komorebi/commit/799739ed6968c86fd0bb1a233a6cb9816b46d384) Allowed support for spaces in config path ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `komorebic/src/main.rs` (+1 -1) </details> ### 📄 Description fix: If the provided configuration path unfortunately includes a space (like C:/Users/FirstName LastName/...), then komorebi fails to find the configuration file as it gets `'--config=C:/Users/FirstName LastName/...'` from komorebic which looks like only `C:/User/FirstName`. Wrapping the path in quotes helps komorebi to find the configuration file. P.S. I'm new to contributing, so if this is improper formatting, or if there's a smart way to supply the config path already without needing this change, I'm open to learning. Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:53:32 +01:00
adam closed this issue 2026-01-05 14:53:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#952
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?