starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #489] [CLOSED] fix: Borders on invisible border window and monocle mode fixes #951

New Issue
Closed
opened 2026-01-05 14:53:32 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:53:32 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/489
Author: @mjblacker
Created: 7/12/2023
Status: ❌ Closed

Base: master ← Head: border_fix

📝 Commits (9)

  • 1b1f723 border fixes for monocle and invisible borders
  • b373116 fix(wm): refer AHK_EXE
  • cecc2e9 chore(deps): bump net2 from 0.2.38 to 0.2.39
  • e0b564a chore(deps): bump serde from 1.0.164 to 1.0.165
  • 01f2e6b chore(deps): bump quote from 1.0.28 to 1.0.29
  • eba9814 fix(wm): lars' secret sauce for min-width apps
  • 36d4726 chore(deps): bump clap from 4.3.8 to 4.3.11
  • 8145ac8 chore(deps): bump serde_yaml from 0.9.21 to 0.9.22
  • d6a079e chore(deps): bump sysinfo from 0.29.2 to 0.29.4

📊 Changes

8 files changed (+126 additions, -80 deletions)

View changed files

📝 Cargo.lock (+48 -27)
📝 komorebi/src/border.rs (+7 -9)
📝 komorebi/src/main.rs (+1 -1)
📝 komorebi/src/process_command.rs (+27 -18)
📝 komorebi/src/process_event.rs (+10 -12)
📝 komorebi/src/window_manager.rs (+15 -10)
📝 komorebi/src/windows_api.rs (+4 -1)
📝 komorebi/src/workspace.rs (+14 -2)

📄 Description

Fix for borders on invisible border windows leaving a gap (contract borders into the window to match the visible area), may only show issue when using thinner than default border width.

Fix for monocle mode border not showing when switching to second workspace as single window (no containers in workspace).

Fix for monocle window not selectable when focusing in direction across multiple screens, would previously show "no container" message as it was only looking in the focused workspace containers ring.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/489 **Author:** [@mjblacker](https://github.com/mjblacker) **Created:** 7/12/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `border_fix` --- ### 📝 Commits (9) - [`1b1f723`](https://github.com/LGUG2Z/komorebi/commit/1b1f723c4fb056b20596e8df86bb33c4373ddf01) border fixes for monocle and invisible borders - [`b373116`](https://github.com/LGUG2Z/komorebi/commit/b373116f6e58ae9d156fcf821d4a3630a9d297e7) fix(wm): refer AHK_EXE - [`cecc2e9`](https://github.com/LGUG2Z/komorebi/commit/cecc2e915ff94ccc29fa1bf80a130c48db4211e1) chore(deps): bump net2 from 0.2.38 to 0.2.39 - [`e0b564a`](https://github.com/LGUG2Z/komorebi/commit/e0b564adaf62420bcf746a690456896bb4829708) chore(deps): bump serde from 1.0.164 to 1.0.165 - [`01f2e6b`](https://github.com/LGUG2Z/komorebi/commit/01f2e6b1619f3d25daf8e6877915ec06d8169592) chore(deps): bump quote from 1.0.28 to 1.0.29 - [`eba9814`](https://github.com/LGUG2Z/komorebi/commit/eba98142b64876d2eac404e551a0202b36777e90) fix(wm): lars' secret sauce for min-width apps - [`36d4726`](https://github.com/LGUG2Z/komorebi/commit/36d4726f269ee53c3e6a9700bdaa966c1f8b9043) chore(deps): bump clap from 4.3.8 to 4.3.11 - [`8145ac8`](https://github.com/LGUG2Z/komorebi/commit/8145ac8810119794da912e63044dfd364673f076) chore(deps): bump serde_yaml from 0.9.21 to 0.9.22 - [`d6a079e`](https://github.com/LGUG2Z/komorebi/commit/d6a079e8a79a70bec6799a10c578e36796196c2c) chore(deps): bump sysinfo from 0.29.2 to 0.29.4 ### 📊 Changes **8 files changed** (+126 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+48 -27) 📝 `komorebi/src/border.rs` (+7 -9) 📝 `komorebi/src/main.rs` (+1 -1) 📝 `komorebi/src/process_command.rs` (+27 -18) 📝 `komorebi/src/process_event.rs` (+10 -12) 📝 `komorebi/src/window_manager.rs` (+15 -10) 📝 `komorebi/src/windows_api.rs` (+4 -1) 📝 `komorebi/src/workspace.rs` (+14 -2) </details> ### 📄 Description Fix for borders on invisible border windows leaving a gap (contract borders into the window to match the visible area), may only show issue when using thinner than default border width. Fix for monocle mode border not showing when switching to second workspace as single window (no containers in workspace). Fix for monocle window not selectable when focusing in direction across multiple screens, would previously show "no container" message as it was only looking in the focused workspace containers ring. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:53:32 +01:00
adam closed this issue 2026-01-05 14:53:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#951
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?