starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

Publish komorebi to winget #93

New Issue
Closed
opened 2026-01-05 14:48:15 +01:00 by adam · 9 comments
adam commented 2026-01-05 14:48:15 +01:00
Owner
Copy Link

Originally created by @0Grit on GitHub (Jun 4, 2022).

Any chance of publishing a winget package?

Originally created by @0Grit on GitHub (Jun 4, 2022). Any chance of publishing a winget package?
adam added the github_actions label 2026-01-05 14:48:15 +01:00
adam closed this issue 2026-01-05 14:48:15 +01:00
adam commented 2026-01-05 14:48:16 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Jun 4, 2022):

I'm not familiar with how WinGet packages work and I don't use it myself.

Happy for anyone who uses it and is familiar with how to package applications for WinGet to submit a PR and walk me through it. 🙏

@LGUG2Z commented on GitHub (Jun 4, 2022): I'm not familiar with how WinGet packages work and I don't use it myself. Happy for anyone who uses it and is familiar with how to package applications for WinGet to submit a PR and walk me through it. 🙏
adam commented 2026-01-05 14:48:16 +01:00
Author
Owner
Copy Link

@sitiom commented on GitHub (Jul 12, 2022):

#158 would have to be resolved first.

@sitiom commented on GitHub (Jul 12, 2022): #158 would have to be resolved first.
adam commented 2026-01-05 14:48:16 +01:00
Author
Owner
Copy Link

@sitiom commented on GitHub (Jul 28, 2022):

@0Grit Please don't close this issue. This hasn't been resolved yet and is still blocked by another issue.

@sitiom commented on GitHub (Jul 28, 2022): @0Grit Please don't close this issue. This hasn't been resolved yet and is still blocked by another issue.
adam commented 2026-01-05 14:48:16 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Jul 28, 2022):

Reopened 👌

@LGUG2Z commented on GitHub (Jul 28, 2022): Reopened 👌
adam commented 2026-01-05 14:48:16 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Aug 12, 2022):

I managed to get an installer working that can install both komorebi.exe and komorebic.exe to C:\Program Files\komorebi and add it to the $PATH, screenshot below:

image

https://github.com/LGUG2Z/komorebi/tree/feature/wix

First run just install (with just installed) to create the binaries in the target dir, then run cargo wix -p komorebi --nocapture -I .\wix\main.wxs (with cargo-wix installed) to generate the installer in ./target/wix.

Can someone please investigate what else is needed to go from having this MSI installer to being able to publish komorebi as a WinGet package?

@LGUG2Z commented on GitHub (Aug 12, 2022): I managed to get an installer working that can install both `komorebi.exe` and `komorebic.exe` to `C:\Program Files\komorebi` and add it to the `$PATH`, screenshot below: ![image](https://user-images.githubusercontent.com/13164844/184259522-895aef12-ad1f-468f-996a-536e34341c87.png) https://github.com/LGUG2Z/komorebi/tree/feature/wix First run `just install` (with `just` installed) to create the binaries in the `target` dir, then run `cargo wix -p komorebi --nocapture -I .\wix\main.wxs` (with `cargo-wix` installed) to generate the installer in `./target/wix`. Can someone please investigate what else is needed to go from having this MSI installer to being able to publish `komorebi` as a WinGet package?
adam commented 2026-01-05 14:48:17 +01:00
Author
Owner
Copy Link

@sitiom commented on GitHub (Aug 12, 2022):

Hmm, perhaps I should be using rustup 🤔
image

@sitiom commented on GitHub (Aug 12, 2022): Hmm, perhaps I should be using rustup 🤔 ![image](https://user-images.githubusercontent.com/56180050/184323500-af1e4036-42e6-444d-8a37-b2f14ce292fc.png)
adam commented 2026-01-05 14:48:17 +01:00
Author
Owner
Copy Link

@sitiom commented on GitHub (Aug 12, 2022):

Another error, no cat in cmd.exe:
image

@sitiom commented on GitHub (Aug 12, 2022): Another error, no `cat` in `cmd.exe`: ![image](https://user-images.githubusercontent.com/56180050/184326041-4a754cde-3160-4370-b8f0-86376efd0f7e.png)
adam commented 2026-01-05 14:48:17 +01:00
Author
Owner
Copy Link

@sitiom commented on GitHub (Aug 12, 2022):

I managed to get an installer working that can install both komorebi.exe and komorebic.exe to C:\Program Files\komorebi and add it to the $PATH, screenshot below:

image

https://github.com/LGUG2Z/komorebi/tree/feature/wix

First run just install (with just installed) to create the binaries in the target dir, then run cargo wix -p komorebi --nocapture -I .\wix\main.wxs (with cargo-wix installed) to generate the installer in ./target/wix.

Can someone please investigate what else is needed to go from having this MSI installer to being able to publish komorebi as a WinGet package?

All good, the installer works. That should already be enough to be added to Winget, as MSI installers support silent installation.

Once the installer is published in the next update, I will create a PR to https://github.com/microsoft/winget-pkgs to add it to Winget. Afterwards, I will create a PR in this repo to use the Winget Releaser action to automate pushing updates to Winget.

@sitiom commented on GitHub (Aug 12, 2022): > I managed to get an installer working that can install both `komorebi.exe` and `komorebic.exe` to `C:\Program Files\komorebi` and add it to the `$PATH`, screenshot below: > > ![image](https://user-images.githubusercontent.com/13164844/184259522-895aef12-ad1f-468f-996a-536e34341c87.png) > > [https://github.com/LGUG2Z/komorebi/tree/feature/wix](https://github.com/LGUG2Z/komorebi/tree/feature/wix?rgh-link-date=2022-08-11T23%3A37%3A25Z) > > First run `just install` (with `just` installed) to create the binaries in the `target` dir, then run `cargo wix -p komorebi --nocapture -I .\wix\main.wxs` (with `cargo-wix` installed) to generate the installer in `./target/wix`. > > Can someone please investigate what else is needed to go from having this MSI installer to being able to publish `komorebi` as a WinGet package? All good, the installer works. That should already be enough to be added to Winget, as MSI installers support silent installation. Once the installer is published in the next update, I will create a PR to https://github.com/microsoft/winget-pkgs to add it to Winget. Afterwards, I will create a PR in this repo to use the [Winget Releaser](https://bittu.eu.org/docs/wr-intro/) action to automate pushing updates to Winget.
adam commented 2026-01-05 14:48:17 +01:00
Author
Owner
Copy Link

@sitiom commented on GitHub (Aug 28, 2022):

https://github.com/microsoft/winget-pkgs/pull/74570

@sitiom commented on GitHub (Aug 28, 2022): https://github.com/microsoft/winget-pkgs/pull/74570
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label github_actions
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#93
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?