starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #405] [MERGED] Feat/initial window rule #911

New Issue
Closed
opened 2026-01-05 14:53:23 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:53:23 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/405
Author: @alvint91
Created: 4/22/2023
Status: ✅ Merged
Merged: 4/30/2023
Merged by: @LGUG2Z

Base: master ← Head: feat/initial-window-rule

📝 Commits (4)

  • c032e90 feat(workspace-rule): add ability to only apply workspace rule on first
  • 6a2d65c style: cargo +nightly fmt --all
  • 2eb6419 refactor(workspace_rules): reduce code duplication
  • 15601a2 feat(workspace-rules): add InitialWorkspaceRule and InitialNamedWorkspaceRule command

📊 Changes

6 files changed (+178 additions, -45 deletions)

View changed files

📝 komorebi-core/src/lib.rs (+2 -0)
📝 komorebi/src/main.rs (+1 -1)
📝 komorebi/src/process_command.rs (+56 -11)
📝 komorebi/src/process_event.rs (+8 -0)
📝 komorebi/src/window_manager.rs (+66 -33)
📝 komorebic/src/main.rs (+45 -0)

📄 Description

I believe should Resolves #263

Added a flag -a or --apply-on-first-show-only to workspace and named workspace rules to only enforce window placement on first show. Closing and reopening window, will enforce the rule again.

Made it default to false to preserve old behavior so it should be a "opt in" thing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/405 **Author:** [@alvint91](https://github.com/alvint91) **Created:** 4/22/2023 **Status:** ✅ Merged **Merged:** 4/30/2023 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `feat/initial-window-rule` --- ### 📝 Commits (4) - [`c032e90`](https://github.com/LGUG2Z/komorebi/commit/c032e901a5892efb99b0b0f80a041c8255fb5ea3) feat(workspace-rule): add ability to only apply workspace rule on first - [`6a2d65c`](https://github.com/LGUG2Z/komorebi/commit/6a2d65c52ffd7ed342abfa8ef414832cecf58c90) style: cargo +nightly fmt --all - [`2eb6419`](https://github.com/LGUG2Z/komorebi/commit/2eb64192d7a3fdfe3847813f3e2d4b73b4f20fdc) refactor(workspace_rules): reduce code duplication - [`15601a2`](https://github.com/LGUG2Z/komorebi/commit/15601a2e2467b8a7d9405cd534f1af893503362d) feat(workspace-rules): add InitialWorkspaceRule and InitialNamedWorkspaceRule command ### 📊 Changes **6 files changed** (+178 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-core/src/lib.rs` (+2 -0) 📝 `komorebi/src/main.rs` (+1 -1) 📝 `komorebi/src/process_command.rs` (+56 -11) 📝 `komorebi/src/process_event.rs` (+8 -0) 📝 `komorebi/src/window_manager.rs` (+66 -33) 📝 `komorebic/src/main.rs` (+45 -0) </details> ### 📄 Description I believe should Resolves #263 Added a flag `-a or --apply-on-first-show-only` to workspace and named workspace rules to only enforce window placement on first show. Closing and reopening window, will enforce the rule again. Made it default to false to preserve old behavior so it should be a "opt in" thing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:53:23 +01:00
adam closed this issue 2026-01-05 14:53:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#911
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?