Originally created by @labuut on GitHub (Jun 1, 2022).
OS: Windows 10
komorebi: 0.1.9-x86_64-pc-windows-msvc
Hello.
I have two-monitor setup and I noticed a strange behaviour:
if I use workspace-layout param for monitor 0 I can't resize layout on monitor 0;
if I use workspace-layout param for monitor 1 I can't resize layout on monitor 1;
If I don't use this param at all resizing works as expected for both 0 and 1 monitors;
Originally created by @labuut on GitHub (Jun 1, 2022).
OS: Windows 10
komorebi: 0.1.9-x86_64-pc-windows-msvc
Hello.
I have two-monitor setup and I noticed a strange behaviour:
- if I use `workspace-layout` param for monitor `0` I can't resize layout on monitor `0`;
- if I use `workspace-layout` param for monitor `1` I can't resize layout on monitor `1`;
- If I don't use this param at all resizing works as expected for both `0` and `1` monitors;
I think this is a case of requiring clearer documentation- the resize-edge and resize-axis commands (and by extension, drag-to-resize) only apply to the bsp layout currently. resize-axis can also be used with custom layouts to increase and reduce the size of the Primary column, but drag-to-resize is only implemented for the bsp layout.
The layout engine is probably the biggest piece of technical debt in this project, and it comes down to the choice of data structure used to hold the windows (a Ring instead of a Tree). Because of this data structure choice, resizing has to be implemented separately for different layout.
I'd welcome a PR to migrate to a data structure that would allow for resizing to be implemented once for any layout (like a tree) from anyone braver than I when it comes to implementing data structures with cyclic references in Rust, but this is not something that I would have any interest in undertaking for myself.
@LGUG2Z commented on GitHub (Jun 2, 2022):
I think this is a case of requiring clearer documentation- the `resize-edge` and `resize-axis` commands (and by extension, drag-to-resize) only apply to the `bsp` layout currently. `resize-axis` can _also_ be used with custom layouts to increase and reduce the size of the `Primary` column, but drag-to-resize is only implemented for the `bsp` layout.
The layout engine is probably the biggest piece of technical debt in this project, and it comes down to the choice of data structure used to hold the windows (a Ring instead of a Tree). Because of this data structure choice, resizing has to be implemented separately for different layout.
I'd welcome a PR to migrate to a data structure that would allow for resizing to be implemented once for any layout (like a tree) from anyone braver than I when it comes to implementing data structures with cyclic references in Rust, but this is not something that I would have any interest in undertaking for myself.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @labuut on GitHub (Jun 1, 2022).
OS: Windows 10
komorebi: 0.1.9-x86_64-pc-windows-msvc
Hello.
I have two-monitor setup and I noticed a strange behaviour:
workspace-layoutparam for monitor0I can't resize layout on monitor0;workspace-layoutparam for monitor1I can't resize layout on monitor1;0and1monitors;@LGUG2Z commented on GitHub (Jun 2, 2022):
I think this is a case of requiring clearer documentation- the
resize-edgeandresize-axiscommands (and by extension, drag-to-resize) only apply to thebsplayout currently.resize-axiscan also be used with custom layouts to increase and reduce the size of thePrimarycolumn, but drag-to-resize is only implemented for thebsplayout.The layout engine is probably the biggest piece of technical debt in this project, and it comes down to the choice of data structure used to hold the windows (a Ring instead of a Tree). Because of this data structure choice, resizing has to be implemented separately for different layout.
I'd welcome a PR to migrate to a data structure that would allow for resizing to be implemented once for any layout (like a tree) from anyone braver than I when it comes to implementing data structures with cyclic references in Rust, but this is not something that I would have any interest in undertaking for myself.
@labuut commented on GitHub (Jun 6, 2022):
Ok, I got it, thank you. I'll try to help you If I have enough time to understand rust)