[PR #261] [CLOSED] feat(wm): add tcp event notifications #828

New Issue

2026-01-05T14:53:07+01:00

adam commented

2026-01-05 14:53:07 +01:00

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/261
Author: @Yusuf007R
Created: 10/14/2022
Status: ❌ Closed

Base: master ← Head: feature/tcp-event-notifications

📝 Commits (1)

0b2b750 feat(wm): add tcp event notifications

📊 Changes

3 files changed (+35 additions, -6 deletions)

View changed files

📝 komorebi/src/main.rs (+26 -1)
📝 komorebi/src/process_command.rs (+7 -3)
📝 komorebi/src/process_event.rs (+2 -2)

📄 Description

This PR allow TCP to receive event notifications. That way if you want to make a custom input handler you do not have to connect to TCP socket and create a named pipe at the same time.

There are some things that I'm not sure how they should be handled

Which TCP Errors should be manage here
Is this okay at this line?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/261 **Author:** [@Yusuf007R](https://github.com/Yusuf007R) **Created:** 10/14/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/tcp-event-notifications` --- ### 📝 Commits (1) - [`0b2b750`](https://github.com/LGUG2Z/komorebi/commit/0b2b75057de0b1bd4903d48690270fad94123970) feat(wm): add tcp event notifications ### 📊 Changes **3 files changed** (+35 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/main.rs` (+26 -1) 📝 `komorebi/src/process_command.rs` (+7 -3) 📝 `komorebi/src/process_event.rs` (+2 -2) </details> ### 📄 Description This PR allow TCP to receive event notifications. That way if you want to make a custom input handler you do not have to connect to TCP socket and create a named pipe at the same time. There are some things that I'm not sure how they should be handled 1. Which TCP Errors should be manage [here](https://github.com/Yusuf007R/komorebi/blob/0b2b75057de0b1bd4903d48690270fad94123970/komorebi/src/main.rs#L377) 2. Is this okay at [this line](https://github.com/Yusuf007R/komorebi/blob/0b2b75057de0b1bd4903d48690270fad94123970/komorebi/src/process_command.rs#L117)? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-01-05 14:53:07 +01:00

adam closed this issue

2026-01-05 14:53:07 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#828