starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #261] [CLOSED] feat(wm): add tcp event notifications #828

New Issue
Closed
opened 2026-01-05 14:53:07 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:53:07 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/261
Author: @Yusuf007R
Created: 10/14/2022
Status: ❌ Closed

Base: master ← Head: feature/tcp-event-notifications

📝 Commits (1)

  • 0b2b750 feat(wm): add tcp event notifications

📊 Changes

3 files changed (+35 additions, -6 deletions)

View changed files

📝 komorebi/src/main.rs (+26 -1)
📝 komorebi/src/process_command.rs (+7 -3)
📝 komorebi/src/process_event.rs (+2 -2)

📄 Description

This PR allow TCP to receive event notifications. That way if you want to make a custom input handler you do not have to connect to TCP socket and create a named pipe at the same time.

There are some things that I'm not sure how they should be handled

  1. Which TCP Errors should be manage here
  2. Is this okay at this line?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/261 **Author:** [@Yusuf007R](https://github.com/Yusuf007R) **Created:** 10/14/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/tcp-event-notifications` --- ### 📝 Commits (1) - [`0b2b750`](https://github.com/LGUG2Z/komorebi/commit/0b2b75057de0b1bd4903d48690270fad94123970) feat(wm): add tcp event notifications ### 📊 Changes **3 files changed** (+35 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/main.rs` (+26 -1) 📝 `komorebi/src/process_command.rs` (+7 -3) 📝 `komorebi/src/process_event.rs` (+2 -2) </details> ### 📄 Description This PR allow TCP to receive event notifications. That way if you want to make a custom input handler you do not have to connect to TCP socket and create a named pipe at the same time. There are some things that I'm not sure how they should be handled 1. Which TCP Errors should be manage [here](https://github.com/Yusuf007R/komorebi/blob/0b2b75057de0b1bd4903d48690270fad94123970/komorebi/src/main.rs#L377) 2. Is this okay at [this line](https://github.com/Yusuf007R/komorebi/blob/0b2b75057de0b1bd4903d48690270fad94123970/komorebi/src/process_command.rs#L117)? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:53:07 +01:00
adam closed this issue 2026-01-05 14:53:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#828
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?