starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

Slack window doesn't get managed properly #81

New Issue
Closed
opened 2026-01-05 14:48:10 +01:00 by adam · 8 comments
adam commented 2026-01-05 14:48:10 +01:00
Owner
Copy Link

Originally created by @pigmej on GitHub (Mar 29, 2022).

Hey,

I have noticed that due to some external (slack?) change slack window stopped to be managed properly. By default window is completely not managed now, when forcing it with komorebic manage-rule exe slack.exe the result is one additional "not used" space (always empty, but komorebi thinks that sth is there.

I think I have noticed similar behavior in the past with some other electron apps like "min browser".

How could I help debugging that?

Originally created by @pigmej on GitHub (Mar 29, 2022). Hey, I have noticed that due to some external (slack?) change slack window stopped to be managed properly. By default window is completely not managed now, when forcing it with `komorebic manage-rule exe slack.exe` the result is one additional "not used" space (always empty, but komorebi thinks that sth is there. I think I have noticed similar behavior in the past with some other electron apps like "min browser". How could I help debugging that?
adam closed this issue 2026-01-05 14:48:10 +01:00
adam commented 2026-01-05 14:48:10 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Mar 29, 2022):

I have just tried reproducing this with Slack v4.24.0 installed via Scoop (on Windows 10) and everything is tiling as expected. Can you provide the Slack version you're using, installation method, OS version etc?

Is there any chance that this could be due to a regression in komorebi? I have pushed quite a few changes over the last couple of days to master.

@LGUG2Z commented on GitHub (Mar 29, 2022): I have just tried reproducing this with Slack v4.24.0 installed via Scoop (on Windows 10) and everything is tiling as expected. Can you provide the Slack version you're using, installation method, OS version etc? Is there any chance that this could be due to a regression in `komorebi`? I have pushed quite a few changes over the last couple of days to `master`.
adam commented 2026-01-05 14:48:11 +01:00
Author
Owner
Copy Link

@pigmej commented on GitHub (Mar 30, 2022):

Hey,

Slack version: ed01bb674f7a8f8103d5b90e1b7abbdb1f413e95 4.25.0 64-bit.

I went back with komorebi till first of February and that was still broken in the same way. So it's unlikely komorebi error, rather slack change (?)

@pigmej commented on GitHub (Mar 30, 2022): Hey, Slack version: `ed01bb674f7a8f8103d5b90e1b7abbdb1f413e95 4.25.0 64-bit.` I went back with komorebi till first of February and that was still broken in the same way. So it's unlikely komorebi error, rather slack change (?)
adam commented 2026-01-05 14:48:11 +01:00
Author
Owner
Copy Link

@pigmej commented on GitHub (Mar 30, 2022):

Yeah,

Checked with slack 4.24 and it works. 4.25 does not work. Seems that they changed how window is constructed. Could be related to other Electron based apps.

@pigmej commented on GitHub (Mar 30, 2022): Yeah, Checked with slack 4.24 and it works. 4.25 does not work. Seems that they changed how window is constructed. Could be related to other Electron based apps.
adam commented 2026-01-05 14:48:11 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Mar 30, 2022):

It looks like 4.25 has removed the WS_CAPTION, WS_BORDER and WS_DLGFRAME styles. WS_CAPTION is one of the ways that komorebi identifies real application windows and ignored abstract HWNDs, so it is a shame that Slack have decided to remove this style.

I tried adding komorebic manage-rule exe slack.exe, and after minimizing and restoring the Slack window, it manages correctly for me, however this is slightly annoying because the rule signal gets sent after the window has already been initially ignored on startup and it requires for the window to be redrawn somehow (closing and re-opening, minimizing and restoring) before it can be managed. I will spend some time looking into a way to automatically try and add any windows associated with new rules to the layout to avoid these manual steps.

@LGUG2Z commented on GitHub (Mar 30, 2022): It looks like 4.25 has removed the `WS_CAPTION`, `WS_BORDER` and `WS_DLGFRAME` styles. `WS_CAPTION` is one of the ways that `komorebi` identifies real application windows and ignored abstract HWNDs, so it is a shame that Slack have decided to remove this style. I tried adding `komorebic manage-rule exe slack.exe`, and after minimizing and restoring the Slack window, it manages correctly for me, however this is slightly annoying because the rule signal gets sent after the window has already been initially ignored on startup and it requires for the window to be redrawn somehow (closing and re-opening, minimizing and restoring) before it can be managed. I will spend some time looking into a way to automatically try and add any windows associated with new rules to the layout to avoid these manual steps.
adam commented 2026-01-05 14:48:11 +01:00
Author
Owner
Copy Link

@pigmej commented on GitHub (Mar 30, 2022):

When i checked on my setup i had some artifects even after redraw of an app, will try to do some screenshots tmrw. But it seemed like an one empty space that komorebi thought is occupied but it was completely empty.

@pigmej commented on GitHub (Mar 30, 2022): When i checked on my setup i had some artifects even after redraw of an app, will try to do some screenshots tmrw. But it seemed like an one empty space that komorebi thought is occupied but it was completely empty.
adam commented 2026-01-05 14:48:11 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Mar 30, 2022):

Do you have komorebic identify-tray-application exe slack.exe set? I was getting an empty space for the latest version of Slack when closing the window until I enabled this.

@LGUG2Z commented on GitHub (Mar 30, 2022): Do you have `komorebic identify-tray-application exe slack.exe` set? I was getting an empty space for the latest version of Slack when closing the window until I enabled this.
adam commented 2026-01-05 14:48:11 +01:00
Author
Owner
Copy Link

@pigmej commented on GitHub (Apr 1, 2022):

That's true but somehow I'm sometimes getting "white" square now for no reason sometimes. I think sth is weird with the most recent slack.

@pigmej commented on GitHub (Apr 1, 2022): That's true but somehow I'm sometimes getting "white" square now for no reason sometimes. I think sth is weird with the most recent slack.
adam commented 2026-01-05 14:48:11 +01:00
Author
Owner
Copy Link

@pigmej commented on GitHub (May 11, 2022):

Issue is gone somehow. I bet slack changed the implementation.

I however see similar issue as the original with min browser.

@pigmej commented on GitHub (May 11, 2022): Issue is gone somehow. I bet slack changed the implementation. I however see similar issue as the original with `min browser`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#81
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?