starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[BUG]: Bar cannot display UWP Icons (PR with fix already exists) #561

New Issue
Closed
opened 2026-01-05 14:51:33 +01:00 by adam · 22 comments
adam commented 2026-01-05 14:51:33 +01:00
Owner
Copy Link

Originally created by @davor-skontra on GitHub (Jan 11, 2025).

Summary

UWP -> Universal Windows Platform

I created a PR in LGUG2>/window-icons repo that merges upstream changes with a fix.

Thought I'd also create this bug report so the PR doesn't go unnoticed.

Version Information

Any version since bar was introduced.

Komorebi Configuration

{
  "$schema": "https://raw.githubusercontent.com/LGUG2Z/komorebi/v0.1.32/schema.bar.json",
  "monitor": {
    "index": 0,
    "work_area_offset": {
      "left": 0,
      "top": 35,
      "right": 0,
      "bottom": 35
    }
  },
  "position": {
    "end": {
      "x": 2560,
      "y": 35,
    }
  },
  "font_family": "JetBrains Mono",
  "theme": {
    "palette": "Base16",
    "name": "TokyoNightStorm",
    "accent": "Base0D"
  },
  "left_widgets": [
    {
      "Komorebi": {
        "workspaces": {
          "enable": true,
          "hide_empty_workspaces": true
        },
        "layout": {
          "enable": true
        },
        "focused_window": {
          "enable": true,
          "show_icon": true
        }
      }
    }
  ],
  "right_widgets": [
    {
      "Media": {
        "enable": true
      }
    },
    {
      "Storage": {
        "enable": true
      }
    },
    {
      "Memory": {
        "enable": true
      }
    },
    {
      "Date": {
        "enable": true,
        "format": "DayDateMonthYear"
      }
    },
    {
      "Time": {
        "enable": true,
        "format": "TwentyFourHour"
      }
    },
    {
      "Battery": {
        "enable": true
      }
    }
  ]
}

Hotkey Configuration

#Requires AutoHotkey v2.0.2
#SingleInstance Force

Komorebic(cmd) {
RunWait(format("komorebic.exe {}", cmd), , "Hide")
}

!q::Komorebic("close")
!m::Komorebic("minimize")

; Focus windows
!h::Komorebic("focus left")
!j::Komorebic("focus down")
!k::Komorebic("focus up")
!l::Komorebic("focus right")

!+[::Komorebic("cycle-focus previous")
!+]::Komorebic("cycle-focus next")

; Move windows
!+h::Komorebic("move left")
!+j::Komorebic("move down")
!+k::Komorebic("move up")
!+l::Komorebic("move right")

; Stack windows
#Left::Komorebic("stack left")
#Down::Komorebic("stack down")
#Up::Komorebic("stack up")
#Right::Komorebic("stack right")
!#Down::Komorebic("unstack")
#,::Komorebic("cycle-stack previous")
#.::Komorebic("cycle-stack next")

; Resize
#^Right::Komorebic("resize-axis horizontal increase")
#^Left::Komorebic("resize-axis horizontal decrease")
#^Up::Komorebic("resize-axis vertical increase")
#^Down::Komorebic("resize-axis vertical decrease")

; Manipulate windows
!t::Komorebic("toggle-float")
!f::Komorebic("toggle-monocle")

; Window manager options
!+r::Komorebic("retile")
!p::Komorebic("toggle-pause")

; Layouts
!x::Komorebic("flip-layout horizontal")
!y::Komorebic("flip-layout vertical")

; Workspaces
#1::Komorebic("focus-workspace 0")
#2::Komorebic("focus-workspace 1")
#3::Komorebic("focus-workspace 2")
#4::Komorebic("focus-workspace 3")
#5::Komorebic("focus-workspace 4")
#6::Komorebic("focus-workspace 5")
#7::Komorebic("focus-workspace 6")
#8::Komorebic("focus-workspace 7")

; Move windows across workspaces
#+1::Komorebic("move-to-workspace 0")
#+2::Komorebic("move-to-workspace 1")
#+3::Komorebic("move-to-workspace 2")
#+4::Komorebic("move-to-workspace 3")
#+5::Komorebic("move-to-workspace 4")
#+6::Komorebic("move-to-workspace 5")
#+7::Komorebic("move-to-workspace 6")
#+8::Komorebic("move-to-workspace 7")

; Run shortcuts
#t::Run("wezterm -e", , "Hide")

Output of komorebic check

No KOMOREBI_CONFIG_HOME detected, defaulting to C:\Users\THEkr

Looking for configuration files in C:\Users\THEkr

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\THEkr.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag

Originally created by @davor-skontra on GitHub (Jan 11, 2025). ### Summary UWP -> Universal Windows Platform I created a [PR in LGUG2>/window-icons](https://github.com/LGUG2Z/windows-icons/pull/1) repo that merges upstream changes with a fix. Thought I'd also create this bug report so the PR doesn't go unnoticed. ### Version Information Any version since bar was introduced. ### Komorebi Configuration ```json { "$schema": "https://raw.githubusercontent.com/LGUG2Z/komorebi/v0.1.32/schema.bar.json", "monitor": { "index": 0, "work_area_offset": { "left": 0, "top": 35, "right": 0, "bottom": 35 } }, "position": { "end": { "x": 2560, "y": 35, } }, "font_family": "JetBrains Mono", "theme": { "palette": "Base16", "name": "TokyoNightStorm", "accent": "Base0D" }, "left_widgets": [ { "Komorebi": { "workspaces": { "enable": true, "hide_empty_workspaces": true }, "layout": { "enable": true }, "focused_window": { "enable": true, "show_icon": true } } } ], "right_widgets": [ { "Media": { "enable": true } }, { "Storage": { "enable": true } }, { "Memory": { "enable": true } }, { "Date": { "enable": true, "format": "DayDateMonthYear" } }, { "Time": { "enable": true, "format": "TwentyFourHour" } }, { "Battery": { "enable": true } } ] } ``` ### Hotkey Configuration #Requires AutoHotkey v2.0.2 #SingleInstance Force Komorebic(cmd) { RunWait(format("komorebic.exe {}", cmd), , "Hide") } !q::Komorebic("close") !m::Komorebic("minimize") ; Focus windows !h::Komorebic("focus left") !j::Komorebic("focus down") !k::Komorebic("focus up") !l::Komorebic("focus right") !+[::Komorebic("cycle-focus previous") !+]::Komorebic("cycle-focus next") ; Move windows !+h::Komorebic("move left") !+j::Komorebic("move down") !+k::Komorebic("move up") !+l::Komorebic("move right") ; Stack windows #Left::Komorebic("stack left") #Down::Komorebic("stack down") #Up::Komorebic("stack up") #Right::Komorebic("stack right") !#Down::Komorebic("unstack") #,::Komorebic("cycle-stack previous") #.::Komorebic("cycle-stack next") ; Resize #^Right::Komorebic("resize-axis horizontal increase") #^Left::Komorebic("resize-axis horizontal decrease") #^Up::Komorebic("resize-axis vertical increase") #^Down::Komorebic("resize-axis vertical decrease") ; Manipulate windows !t::Komorebic("toggle-float") !f::Komorebic("toggle-monocle") ; Window manager options !+r::Komorebic("retile") !p::Komorebic("toggle-pause") ; Layouts !x::Komorebic("flip-layout horizontal") !y::Komorebic("flip-layout vertical") ; Workspaces #1::Komorebic("focus-workspace 0") #2::Komorebic("focus-workspace 1") #3::Komorebic("focus-workspace 2") #4::Komorebic("focus-workspace 3") #5::Komorebic("focus-workspace 4") #6::Komorebic("focus-workspace 5") #7::Komorebic("focus-workspace 6") #8::Komorebic("focus-workspace 7") ; Move windows across workspaces #+1::Komorebic("move-to-workspace 0") #+2::Komorebic("move-to-workspace 1") #+3::Komorebic("move-to-workspace 2") #+4::Komorebic("move-to-workspace 3") #+5::Komorebic("move-to-workspace 4") #+6::Komorebic("move-to-workspace 5") #+7::Komorebic("move-to-workspace 6") #+8::Komorebic("move-to-workspace 7") ; Run shortcuts #t::Run("wezterm -e", , "Hide") ### Output of komorebic check No KOMOREBI_CONFIG_HOME detected, defaulting to C:\Users\THEkr Looking for configuration files in C:\Users\THEkr Found komorebi.json; this file can be passed to the start command with the --config flag Found C:\Users\THEkr\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag
adam added the bugi-will-probably-work-on-thiskomorebi-bar0.1.36 labels 2026-01-05 14:51:33 +01:00
adam closed this issue 2026-01-05 14:51:33 +01:00
adam commented 2026-01-05 14:51:34 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Jan 12, 2025):

Thanks for opening this PR! I actually didn't get notified of the underlying PR to the windows-icons repo, I'll take a look soon 🤞

@LGUG2Z commented on GitHub (Jan 12, 2025): Thanks for opening this PR! I actually didn't get notified of the underlying PR to the `windows-icons` repo, I'll take a look soon 🤞
adam commented 2026-01-05 14:51:34 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Jan 12, 2025):

I played with this a little today and the issue with UWP apps is that they are all running as ApplicationFrameworkHost.exe, and when you pass the process_id of these apps to the library to go and look up their icons, they can't be uniquely identified 🤔

Not sure how to proceed with this, maybe @AmnWeb has some ideas from yasb that we can bring here.

@LGUG2Z commented on GitHub (Jan 12, 2025): I played with this a little today and the issue with UWP apps is that they are all running as `ApplicationFrameworkHost.exe`, and when you pass the `process_id` of these apps to the library to go and look up their icons, they can't be uniquely identified 🤔 Not sure how to proceed with this, maybe @AmnWeb has some ideas from yasb that we can bring here.
adam commented 2026-01-05 14:51:34 +01:00
Author
Owner
Copy Link

@amnweb commented on GitHub (Jan 12, 2025):

UWP apps might need a moment to start under ApplicationFrameHost, maybe that's the problem?
An example of how I solved this

cd336fa718/src/core/widgets/yasb/active_window.py (L195)

@amnweb commented on GitHub (Jan 12, 2025): UWP apps might need a moment to start under ApplicationFrameHost, maybe that's the problem? An example of how I solved this https://github.com/amnweb/yasb/blob/cd336fa718c39d30ac4eb1a8e29fd920fae5e38f/src/core/widgets/yasb/active_window.py#L195
adam commented 2026-01-05 14:51:34 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Jan 12, 2025):

Thanks for that Amnweb! I'll try the same approach!

@davor-skontra commented on GitHub (Jan 12, 2025): Thanks for that Amnweb! I'll try the same approach!
adam commented 2026-01-05 14:51:34 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Jan 15, 2025):

Ok, I did some debugging and it looks like window-icons is actually able to get a path to the windows terminal icon (which exists in the file system, checked).

The process fails on the next step when trying to read image to base 64.

pub fn get_uwp_icon(process_path: &str) -> Result<RgbaImage, Box<dyn Error>> {
    let icon_path = &get_icon_file_path(process_path)?;
    let base64 = read_image_to_base64(icon_path)?;  // I never get beyond this point with Windows Terminal
    let icon = get_icon_from_base64(&base64)?;
    Ok(icon)
}

I think it has to do with the icon format. Arc Browser uses .ico, terminal uses .png . Arc Browser icon gets loaded, Terminal does not. Both are UWP apps.

I'm not sure how encodings work and what they do. also don't know much about these image formats in general.

I'll try to figure it out over the weekend but advice is welcome. 😁

@davor-skontra commented on GitHub (Jan 15, 2025): Ok, I did some debugging and it looks like `window-icons` is actually able to get a path to the windows terminal icon (which exists in the file system, checked). The process fails on the next step when trying to read image to base 64. ```Rust pub fn get_uwp_icon(process_path: &str) -> Result<RgbaImage, Box<dyn Error>> { let icon_path = &get_icon_file_path(process_path)?; let base64 = read_image_to_base64(icon_path)?; // I never get beyond this point with Windows Terminal let icon = get_icon_from_base64(&base64)?; Ok(icon) } ``` I think it has to do with the icon format. Arc Browser uses `.ico`, terminal uses `.png` . Arc Browser icon gets loaded, Terminal does not. Both are UWP apps. I'm not sure how encodings work and what they do. also don't know much about these image formats in general. I'll try to figure it out over the weekend but advice is welcome. 😁
adam commented 2026-01-05 14:51:34 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Jan 15, 2025):

I think I remember when I looked inside the path given for the file on my system, the file referenced didn't actually exist 👀 Can you check if this is the case for you also?

@LGUG2Z commented on GitHub (Jan 15, 2025): I think I remember when I looked inside the path given for the file on my system, the file referenced didn't actually exist 👀 Can you check if this is the case for you also?
adam commented 2026-01-05 14:51:34 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Jan 18, 2025):

Double checked. Yeah you are right, that exact file does not exist.

window-icons is making use of the ApplicationMaifest.xml to figure out where the icon is, assuming it is within the <Logo> tags.

However Terminal seems to be doing something else with that.

The manifest has this

<Logo>Images\StoreLogo.png</Logo>

While the files have info appended to the name like here.

image

I'm not sure what's happening here or how common this approach is with other uwp applications.

@davor-skontra commented on GitHub (Jan 18, 2025): Double checked. Yeah you are right, that exact file does not exist. `window-icons` is making use of the `ApplicationMaifest.xml` to figure out where the icon is, assuming it is within the `<Logo>` tags. However Terminal seems to be doing something else with that. The manifest has this `<Logo>Images\StoreLogo.png</Logo> ` While the files have info appended to the name like here. ![image](https://github.com/user-attachments/assets/0385b204-e600-4f65-aa33-cb01a8033a07) I'm not sure what's happening here or how common this approach is with other uwp applications.
adam commented 2026-01-05 14:51:34 +01:00
Author
Owner
Copy Link

@amnweb commented on GitHub (Jan 18, 2025):

I think you need to find VisualElements in the manifest and look for Square44x44Logo, this should be a png, jpg or jpeg image and this is what you need for the icon.

Sorry I don't know about Rust, but here's what I mean, something like example below (Python) to cover all Win11 and Win10

root = ET.parse(manifest_path)
element = root.find(".//VisualElements")
if element is None:
    element = root.find(".//{http://schemas.microsoft.com/appx/manifest/uap/windows10}VisualElements")
if not element :
    return None
if "Square44x44Logo" not in element .attrib:
    return None

Then, once you get the Square44x44 logo path, you can easily manipulate the image as you wish.

For more complex function see this file https://github.com/amnweb/yasb/blob/main/src/core/utils/win32/app_icons.py

Edit:

Image

@amnweb commented on GitHub (Jan 18, 2025): I think you need to find `VisualElements` in the manifest and look for `Square44x44Logo`, this should be a png, jpg or jpeg image and this is what you need for the icon. Sorry I don't know about Rust, but here's what I mean, something like example below (Python) to cover all Win11 and Win10 ``` root = ET.parse(manifest_path) element = root.find(".//VisualElements") if element is None: element = root.find(".//{http://schemas.microsoft.com/appx/manifest/uap/windows10}VisualElements") if not element : return None if "Square44x44Logo" not in element .attrib: return None ``` Then, once you get the Square44x44 logo path, you can easily manipulate the image as you wish. For more complex function see this file https://github.com/amnweb/yasb/blob/main/src/core/utils/win32/app_icons.py Edit: ![Image](https://github.com/user-attachments/assets/14eb86ae-8cc9-48d4-81df-150e84e242b8)
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Jan 19, 2025):

Thanks a bunch @amnweb !

Looks like there are a quite a few things that would need handling to get this working in a Microsoft way but a quick hack for now seems reasonable

Windows Terminal makes use of icon scaling so to solve I could just grab the closest Icon to 100% scale I can find and if that doesn't work I can search upward for a closest larger scale icon.

Another thing I didn't consider, but you seem to be handling to a degree are localizations, contrast and things like that. I don't have a clear plan there yet.

@davor-skontra commented on GitHub (Jan 19, 2025): Thanks a bunch @amnweb ! Looks like there are a quite a [few](https://github.com/amnweb/yasb/blob/53b6f7c893febb8b5a522cd7f8acdb313c69b037/src/core/utils/win32/app_icons.py#L166) things that would need handling to get this working in a Microsoft way but a quick hack for now seems reasonable Windows Terminal [makes use of icon scaling](https://learn.microsoft.com/en-us/uwp/schemas/appxpackage/uapmanifestschema/element-uap-visualelements#remarks) so to solve I could just grab the closest Icon to 100% scale I can find and if that doesn't work I can search upward for a closest larger scale icon. Another thing I didn't consider, but you seem to be handling to a degree are localizations, contrast and things like that. I don't have a clear plan there yet.
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Jan 20, 2025):

OK, got something working though could be more polished. More info in the original PR.

@davor-skontra commented on GitHub (Jan 20, 2025): OK, got something working though could be more polished. More info in the [original PR](https://github.com/LGUG2Z/windows-icons/pull/1#discussion_r1922774480).
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Jan 20, 2025):

We are definitely getting closer! I can see the WT icon coming through properly now. The next issue to tackle will be handling the Icons for ApplicationFrameworkHost.exe apps like Settings, which are still showing what I imagine is a default/fallback icon from where:

Image

@LGUG2Z commented on GitHub (Jan 20, 2025): We are definitely getting closer! I can see the WT icon coming through properly now. The next issue to tackle will be handling the Icons for `ApplicationFrameworkHost.exe` apps like Settings, which are still showing what I imagine is a default/fallback icon from where: ![Image](https://github.com/user-attachments/assets/105eb281-9e54-4faf-ad5b-f7355cbf976c)
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Jan 20, 2025):

Alrriighty. That ApllicationFrameworkHost is another system then. I'll try to tackle that one as well.

Am also hoping to tackle scaling in such a way that you could pass that down as a param when calling get_icon_by_* methods

pub struct IconMatcher {
    pub display_scale: Option<i8>,
}
pub fn get_icon_by_process_id(process_id: u32, icon_matcher: Option<IconMatcher>) -> Option<RgbaImage> {
    let path = get_process_path(process_id).ok()?;

    if path.contains("WindowsApps") {
        get_uwp_icon(&path, icon_matcher).ok()
    } else {
        get_icon_by_path(&path)
    }
}

I think this is a better approach then the library trying to figure out what the user wants to do and reading the scale info directly from system.

If needed I can also do that in a non API breaking way by adding a separate method for using the matcher.

Side note, that IconMatcher struct would later also pass things like localization data down the line so we can get the correct icon for localized apps.

@davor-skontra commented on GitHub (Jan 20, 2025): Alrriighty. That ApllicationFrameworkHost is another system then. I'll try to tackle that one as well. Am also hoping to tackle scaling in such a way that you could pass that down as a param when calling `get_icon_by_*` methods ```Rust pub struct IconMatcher { pub display_scale: Option<i8>, } pub fn get_icon_by_process_id(process_id: u32, icon_matcher: Option<IconMatcher>) -> Option<RgbaImage> { let path = get_process_path(process_id).ok()?; if path.contains("WindowsApps") { get_uwp_icon(&path, icon_matcher).ok() } else { get_icon_by_path(&path) } } ``` I think this is a better approach then the library trying to figure out what the user wants to do and reading the scale info directly from system. If needed I can also do that in a non API breaking way by adding a separate method for using the matcher. Side note, that `IconMatcher` struct would later also pass things like localization data down the line so we can get the correct icon for localized apps.
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Jan 27, 2025):

Just FYI, I haven't given up on this. 😬

Had a busy weekend, so no progress then but today I managed to add that icon scaling support.

This should also make it easier to support other icon sizes, localizations and accessibility things like high contrast icons in the future.

Anyhow what I did is pretty similar to what Amnweb is doing here

The default function signatures remain as they were for backward compatibility so no API breaking changes but if you want to make use of that with the komorebi-bar you could.

The ApplicationFrameworkHost is next on my To-Do list.

@davor-skontra commented on GitHub (Jan 27, 2025): Just FYI, I haven't given up on this. 😬 Had a busy weekend, so no progress then but today I managed to add that icon scaling support. This should also make it easier to support other icon sizes, localizations and accessibility things like high contrast icons in the future. Anyhow what I did is pretty similar to what Amnweb is doing [here](https://github.com/amnweb/yasb/blob/main/src/core/utils/win32/app_icons.py) The default function signatures remain as they were for backward compatibility so no API breaking changes but if you want to make use of that with the `komorebi-bar` you could. The ApplicationFrameworkHost is next on my To-Do list.
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Feb 16, 2025):

After a few weeks of making a hole in the wall with my forehead I got it to work! 🥳

I had to add a new public API function to look up icons with HWND-s as I couldn't figure out how to do it from process_id

I need to clean things up a bit, still, remove unwarps and debug lines that might be lurking etc, but you can try it already if you'd like, just use the get_icon_by_hwnd or get_icon_by_hwnd_matching methods instead!

Ill let you know when I've cleaned things up for hopefully final round of reviews but meanwhile do let me know if there is something wrong from the API side that would need to be adressed 🙏 !

@davor-skontra commented on GitHub (Feb 16, 2025): After a few weeks of making a hole in the wall with my forehead I got it to work! 🥳 I had to add a new public API function to look up icons with `HWND`-s as I couldn't figure out how to do it from `process_id` I need to clean things up a bit, still, remove unwarps and debug lines that might be lurking etc, but you can try it already if you'd like, just use the `get_icon_by_hwnd` or `get_icon_by_hwnd_matching` methods instead! Ill let you know when I've cleaned things up for hopefully final round of reviews but meanwhile do let me know if there is something wrong from the API side that would need to be adressed 🙏 !
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Mar 2, 2025):

Hello! This should be ready for another review!

I wrote a bit about the implementation details in the PR.

@davor-skontra commented on GitHub (Mar 2, 2025): Hello! This should be ready for another review! I wrote a bit about the[ implementation details](https://github.com/LGUG2Z/windows-icons/pull/1#issuecomment-2692733784) in the PR.
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Mar 3, 2025):

Thank you! I will try to take a look at all of your great work this week 🤞

@LGUG2Z commented on GitHub (Mar 3, 2025): Thank you! I will try to take a look at all of your great work this week 🤞
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Mar 22, 2025):

Image

@davor-skontra commented on GitHub (Mar 22, 2025): ![Image](https://github.com/user-attachments/assets/6e555572-ab9e-40de-80ed-b5ec36658672)
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Mar 22, 2025):

I did look at this! As far as I can tell there are no breakages, but I was still not able to get icons showing for UWP apps like Settings etc.

I'll tag this with 0.1.36 and we can get this into the next nightly after the 0.1.35 release for some wider feedback 🤞

@LGUG2Z commented on GitHub (Mar 22, 2025): I did look at this! As far as I can tell there are no breakages, but I was still not able to get icons showing for UWP apps like Settings etc. I'll tag this with 0.1.36 and we can get this into the next nightly after the 0.1.35 release for some wider feedback 🤞
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Mar 22, 2025):

Thanks! That's strange, I had settings and other icons working. I'll check what's up with that!

@davor-skontra commented on GitHub (Mar 22, 2025): Thanks! That's strange, I had settings and other icons working. I'll check what's up with that!
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Mar 23, 2025):

Image

This is what I see when using this commit of windows-icons on komorebi-bar

windows-icons = { git = "https://github.com/LGUG2Z/windows-icons", rev = "e12e7bf2b91c49987a5e7de2e16e8556960ca1f5" }
@LGUG2Z commented on GitHub (Mar 23, 2025): ![Image](https://github.com/user-attachments/assets/b81e338f-8f6b-483c-869d-6f9fba277681) This is what I see when using this commit of windows-icons on komorebi-bar ```toml windows-icons = { git = "https://github.com/LGUG2Z/windows-icons", rev = "e12e7bf2b91c49987a5e7de2e16e8556960ca1f5" } ```
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Mar 23, 2025):

Nevermind, I just need to read more carefully - I can now see this once I change the fn to the hwnd variant:

Image

@LGUG2Z commented on GitHub (Mar 23, 2025): Nevermind, I just need to read more carefully - I can now see this once I change the fn to the hwnd variant: ![Image](https://github.com/user-attachments/assets/bb867bd0-de9e-429b-aba1-224506b475fd)
adam commented 2026-01-05 14:51:35 +01:00
Author
Owner
Copy Link

@davor-skontra commented on GitHub (Mar 23, 2025):

Awsome! Thanks for the PR!

Komorebi is an awesome piece of software and it makes me happy I was able to contribute to it in a small way! Working with Rust for the first time was interesting as well!

@davor-skontra commented on GitHub (Mar 23, 2025): Awsome! Thanks for the PR! Komorebi is an awesome piece of software and it makes me happy I was able to contribute to it in a small way! Working with Rust for the first time was interesting as well!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label 0.1.36 bug i-will-probably-work-on-this komorebi-bar
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#561
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?