mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-01-11 14:40:25 +01:00
[BUG]: Can't cycle stack windows if stack is monocled #502
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alex-ds13 on GitHub (Oct 21, 2024).
Summary
If we monocle a stack container we won't be able to use the
cycle-stackorfocus-stack-windowcommands since those try to operate on theself.focused_containerof the window manager which when monocled is incorrect, since it only looks on the workspace containers ignoring the monocle container.Version Information
0.1.29+
Komorebi Configuration
Hotkey Configuration
(not needed)
Output of komorebic check
(not needed)
@alex-ds13 commented on GitHub (Oct 21, 2024):
@LGUG2Z Feel free to assign this one to me as well.
I will fix this one by adding a check for monocle containers first.
However I feel that a bunch of this issues would be non-existent if instead of removing the containers from the workspace
containersring to move that container to the monocle, we kept the containers always on the ring and simply set the container id to the monocle. Same thing forfloating_windowsthey could still have their container on the ring and then thefloating_windowswould be a vec of ids. This way the focused container could always be get easily from the ring. And even floating windows could be focused meaning that when changing workspaces if that floating window was focused we would be able to set it to focused again. But this is a discussion for another time.