starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

komorebic gui reports null on non-null titles/paths/exes/et. cetera #485

New Issue
Closed
opened 2026-01-05 14:51:01 +01:00 by adam · 3 comments
adam commented 2026-01-05 14:51:01 +01:00
Owner
Copy Link

Originally created by @codyduong on GitHub (Oct 11, 2024).

Summary

This is probably a to_string() failing (or similar). Works fine in komorebi log.

komorebic gui
komorebic gui

komorebic log

komorebi::process_event: processed: (hwnd: 7934510, title: Comparing master...feature/reduce-notifications · LGUG2Z/komorebi — Mozilla Firefox, exe: firefox.exe, class: MozillaWindowClass)

Version Information

OS Name:                   Microsoft Windows 11 Home
komorebic 0.1.30
branch:feature/reduce-notifications
commit_hash:b3a9c57f
build_time:2024-10-11 17:36:36 +00:00
build_env:rustc 1.81.0 (eeb90cda1 2024-09-04),stable-x86_64-pc-windows-msvc

Should note this occurs on 0.1.28^ as well, or probably every version since komorebic gui was introduced.

Komorebi Configuration

N/A

Hotkey Configuration

N/A

Output of komorebic check

N/A

Originally created by @codyduong on GitHub (Oct 11, 2024). ### Summary This is probably a to_string() failing (or similar). Works fine in `komorebi log`. `komorebic gui` ![komorebic gui](https://github.com/user-attachments/assets/38bc0bd2-2e55-4f00-adf0-5a28406137e1) `komorebic log` ``` komorebi::process_event: processed: (hwnd: 7934510, title: Comparing master...feature/reduce-notifications · LGUG2Z/komorebi — Mozilla Firefox, exe: firefox.exe, class: MozillaWindowClass) ``` ### Version Information ``` OS Name: Microsoft Windows 11 Home komorebic 0.1.30 branch:feature/reduce-notifications commit_hash:b3a9c57f build_time:2024-10-11 17:36:36 +00:00 build_env:rustc 1.81.0 (eeb90cda1 2024-09-04),stable-x86_64-pc-windows-msvc ``` Should note this occurs on 0.1.28^ as well, or probably every version since komorebic gui was introduced. ### Komorebi Configuration N/A ### Hotkey Configuration N/A ### Output of komorebic check N/A
adam added the bug label 2026-01-05 14:51:01 +01:00
adam closed this issue 2026-01-05 14:51:02 +01:00
adam commented 2026-01-05 14:51:02 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Oct 11, 2024):

7f42042322/komorebi/src/window.rs (L471-L546)

Right now I think this might be expected behaviour; there are a bunch of early returns here to ensure that we are not wasting CPU cycles trying to further validate a window for management if we already know it has failed early checks.

@LGUG2Z commented on GitHub (Oct 11, 2024): https://github.com/LGUG2Z/komorebi/blob/7f420423229afabea6de4b2d117474181ccf67ec/komorebi/src/window.rs#L471-L546 Right now I think this might be expected behaviour; there are a bunch of early returns here to ensure that we are not wasting CPU cycles trying to further validate a window for management if we already know it has failed early checks.
adam commented 2026-01-05 14:51:02 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Oct 11, 2024):

In the case of your screenshot, I'm thinking with !allow_cloaked and is_cloaked you hit the (false, true) matcher (under _) and this skipped any title/path/exe lookups.

@LGUG2Z commented on GitHub (Oct 11, 2024): In the case of your screenshot, I'm thinking with `!allow_cloaked` and `is_cloaked` you hit the `(false, true)` matcher (under `_`) and this skipped any title/path/exe lookups.
adam commented 2026-01-05 14:51:02 +01:00
Author
Owner
Copy Link

@codyduong commented on GitHub (Oct 11, 2024):

Oh, I see. I was using komorebic gui to try and get some .exe names on workspaces not currently visible to float-rule them. Makes sense I guess.

@codyduong commented on GitHub (Oct 11, 2024): Oh, I see. I was using komorebic gui to try and get some .exe names on workspaces not currently visible to float-rule them. Makes sense I guess.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#485
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?