starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[BUG]: Container persists after minimizing window with minimum_window_height set #459

New Issue
Open
opened 2026-01-05 14:50:52 +01:00 by adam · 4 comments
adam commented 2026-01-05 14:50:52 +01:00
Owner
Copy Link

Originally created by @sundance on GitHub (Aug 27, 2024).

Describe the bug
After setting "minimum_window_height" or "minimum_window_width" above a certain threshold containers don't get destroyed when windows are minimized

To Reproduce
Steps to reproduce the behavior:

  1. Add "minimum_window_height": 400 or "minimum_window_width": 400 to your config
    (on my setup the thresholds are width : 160, height : 28)
  2. Open another window
  3. Minimize that window

Screenshots and Videos

https://github.com/user-attachments/assets/21de911b-b9f5-40db-9a5b-5b145f6b4d64

Operating System

OS Name:                   Microsoft Windows 11 Pro
OS Version:                10.0.22631 N/A Build 22631

komorebic check Output

No KOMOREBI_CONFIG_HOME detected, defaulting to C:\Users\sysadmin

Looking for configuration files in C:\Users\sysadmin

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\sysadmin\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag
Originally created by @sundance on GitHub (Aug 27, 2024). **Describe the bug** After setting "minimum_window_height" or "minimum_window_width" above a certain threshold containers don't get destroyed when windows are minimized **To Reproduce** Steps to reproduce the behavior: 1. Add "minimum_window_height": 400 or "minimum_window_width": 400 to your config (on my setup the thresholds are width : 160, height : 28) 2. Open another window 3. Minimize that window **Screenshots and Videos** https://github.com/user-attachments/assets/21de911b-b9f5-40db-9a5b-5b145f6b4d64 **Operating System** ``` OS Name: Microsoft Windows 11 Pro OS Version: 10.0.22631 N/A Build 22631 ``` **`komorebic check` Output** ``` No KOMOREBI_CONFIG_HOME detected, defaulting to C:\Users\sysadmin Looking for configuration files in C:\Users\sysadmin Found komorebi.json; this file can be passed to the start command with the --config flag Found C:\Users\sysadmin\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag ```
adam added the bugi-will-not-work-on-thiskomorebi labels 2026-01-05 14:50:52 +01:00
adam commented 2026-01-05 14:50:52 +01:00
Author
Owner
Copy Link

@Impasse52 commented on GitHub (Jan 15, 2025):

I'm experiencing this same behavior on v0.1.33, adding any of these entries to my komorebi.json causes minimizations to leave gaps in the tiling.

@Impasse52 commented on GitHub (Jan 15, 2025): I'm experiencing this same behavior on v0.1.33, adding any of these entries to my komorebi.json causes minimizations to leave gaps in the tiling.
adam commented 2026-01-05 14:50:52 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Jan 23, 2025):

Given that I strongly discourage the use of these options, I don't think I'll be doing any further work on this myself. Truth be told, I regret adding this "feature" at all 😅

@LGUG2Z commented on GitHub (Jan 23, 2025): Given that I strongly discourage the use of these options, I don't think I'll be doing any further work on this myself. Truth be told, I regret adding this "feature" at all 😅
adam commented 2026-01-05 14:50:52 +01:00
Author
Owner
Copy Link

@Impasse52 commented on GitHub (Jan 24, 2025):

Given that I strongly discourage the use of these options, I don't think I'll be doing any further work on this myself. Truth be told, I regret adding this "feature" at all 😅

That's fair. Do you have any recommendations on handling small, "temporary" windows? That would be my main use case. I just feel like windows similar to Discord's or Steam's loading screen shouldn't be tiled at all, it just feels heavier than it should when the whole layout changes completely for just a sec, especially with animations turned on. :(

@Impasse52 commented on GitHub (Jan 24, 2025): > Given that I strongly discourage the use of these options, I don't think I'll be doing any further work on this myself. Truth be told, I regret adding this "feature" at all 😅 That's fair. Do you have any recommendations on handling small, "temporary" windows? That would be my main use case. I just feel like windows similar to Discord's or Steam's loading screen shouldn't be tiled at all, it just feels heavier than it should when the whole layout changes completely for just a sec, especially with animations turned on. :(
adam commented 2026-01-05 14:50:53 +01:00
Author
Owner
Copy Link

@alex-ds13 commented on GitHub (Feb 26, 2025):

Given that I strongly discourage the use of these options, I don't think I'll be doing any further work on this myself. Truth be told, I regret adding this "feature" at all 😅

That's fair. Do you have any recommendations on handling small, "temporary" windows? That would be my main use case. I just feel like windows similar to Discord's or Steam's loading screen shouldn't be tiled at all, it just feels heavier than it should when the whole layout changes completely for just a sec, especially with animations turned on. :(

You can use the komorebi-gui and komorebic visible-windows to pinpoint all the details about those windows and create composite rules for them as ignore_rules. As an example most apps that open a splash window on start will have that window with some different class so you can create a composite rule like this:

"ignore_rules": [
    [
        {
            "kind": "Class",
            "id": "blablaSplash",
            "matching_strategy": "Contains",
        },
        {
            "kind": "Exe",
            "id": "awesome_app.exe",
            "matching_strategy": "Equals",
        }
    ]
]
@alex-ds13 commented on GitHub (Feb 26, 2025): > > Given that I strongly discourage the use of these options, I don't think I'll be doing any further work on this myself. Truth be told, I regret adding this "feature" at all 😅 > > That's fair. Do you have any recommendations on handling small, "temporary" windows? That would be my main use case. I just feel like windows similar to Discord's or Steam's loading screen shouldn't be tiled at all, it just feels heavier than it should when the whole layout changes completely for just a sec, especially with animations turned on. :( You can use the `komorebi-gui` and `komorebic visible-windows` to pinpoint all the details about those windows and create composite rules for them as `ignore_rules`. As an example most apps that open a splash window on start will have that window with some different class so you can create a composite rule like this: ```json "ignore_rules": [ [ { "kind": "Class", "id": "blablaSplash", "matching_strategy": "Contains", }, { "kind": "Exe", "id": "awesome_app.exe", "matching_strategy": "Equals", } ] ] ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label bug i-will-not-work-on-this komorebi
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#459
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?