starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[BUG]: border implementation parameters syntax #434

New Issue
Closed
opened 2026-01-05 14:50:43 +01:00 by adam · 2 comments
adam commented 2026-01-05 14:50:43 +01:00
Owner
Copy Link

Originally created by @azinsharaf on GitHub (Jul 21, 2024).

Describe the bug
border_implementation options in the config file are Komorebi and Windows (first charecter is uppercase) but the help document (komorebic border-implementation --help) shows them as komorebi and windows. And using them doesn't work.

Expected behavior
Since the parameters are case sensitvie, their syntax should match between config file and help.

Operating System

OS Name:                   Microsoft Windows 11 Pro
OS Version:                10.0.22631 N/A Build 22631

komorebic check Output
Provide the output of komorebic check

KOMOREBI_CONFIG_HOME detected: C:\Users\asharaf\.config\komorebi

Looking for configuration files in C:\Users\asharaf\.config\komorebi

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\asharaf\.config\whkd\whkdrc; key bindings will be loaded from here when whkd is
started, and you can start it automatically using the --whkd flag
Originally created by @azinsharaf on GitHub (Jul 21, 2024). **Describe the bug** `border_implementation` options in the config file are `Komorebi` and `Windows` (first charecter is uppercase) but the help document (`komorebic border-implementation --help`) shows them as `komorebi` and `windows`. And using them doesn't work. **Expected behavior** Since the parameters are case sensitvie, their syntax should match between config file and help. **Operating System** ``` OS Name: Microsoft Windows 11 Pro OS Version: 10.0.22631 N/A Build 22631 ``` **`komorebic check` Output** Provide the output of `komorebic check` ``` KOMOREBI_CONFIG_HOME detected: C:\Users\asharaf\.config\komorebi Looking for configuration files in C:\Users\asharaf\.config\komorebi Found komorebi.json; this file can be passed to the start command with the --config flag Found C:\Users\asharaf\.config\whkd\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag ```
adam added the bug label 2026-01-05 14:50:43 +01:00
adam closed this issue 2026-01-05 14:50:44 +01:00
adam commented 2026-01-05 14:50:44 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Jul 21, 2024):

Can you check if running the CLI command triggers any errors in the logs?

0f9c23b6f4/komorebi/src/process_command.rs (L1289-L1293)

There is a minimum version requirement for this, but from your OS info it looks like you are above 22000 🤔

DWMWA_BORDER_COLOR
Use with DwmSetWindowAttribute. Specifies the color of the window border. The pvAttribute parameter points to a value of type COLORREF. The app is responsible for changing the border color according to state changes, such as a change in window activation.

Specifying DWMWA_COLOR_NONE (value 0xFFFFFFFE) for the color will suppress the drawing of the window border. This makes it possible to have a rounded window with no border.

Specifying DWMWA_COLOR_DEFAULT (value 0xFFFFFFFF) for the color will reset the window back to using the system's default behavior for the border color.

This value is supported starting with Windows 11 Build 22000.

The casing is unrelated- JSON gets serialized/deserialized with TitleCase and the CLI sticks to lowercase to match command line conventions.

@LGUG2Z commented on GitHub (Jul 21, 2024): Can you check if running the CLI command triggers any errors in the logs? https://github.com/LGUG2Z/komorebi/blob/0f9c23b6f49798788be555270fae215184786875/komorebi/src/process_command.rs#L1289-L1293 There is a minimum version requirement for this, but from your OS info it looks like you are above `22000` 🤔 > `DWMWA_BORDER_COLOR` > Use with [DwmSetWindowAttribute](https://learn.microsoft.com/en-us/windows/win32/api/dwmapi/nf-dwmapi-dwmsetwindowattribute). Specifies the color of the window border. The pvAttribute parameter points to a value of type [COLORREF](https://learn.microsoft.com/en-us/windows/win32/gdi/colorref). The app is responsible for changing the border color according to state changes, such as a change in window activation. > > Specifying DWMWA_COLOR_NONE (value 0xFFFFFFFE) for the color will suppress the drawing of the window border. This makes it possible to have a rounded window with no border. > > Specifying DWMWA_COLOR_DEFAULT (value 0xFFFFFFFF) for the color will reset the window back to using the system's default behavior for the border color. > > This value is supported starting with Windows 11 Build 22000. The casing is unrelated- JSON gets serialized/deserialized with TitleCase and the CLI sticks to lowercase to match command line conventions.
adam commented 2026-01-05 14:50:44 +01:00
Author
Owner
Copy Link

@azinsharaf commented on GitHub (Jul 21, 2024):

no erorr in the logs.

komorebic border-implementation komorebi
output:
2024-07-21T17:08:28.232937Z INFO process_event{event=FocusChange(SystemForeground, Window { hwnd: 3542614 })}: komorebi::process_event: processed

komorebic border-implementation Komorebi
output:

error: invalid value 'Komorebi' for '<STYLE>'
  [possible values: komorebi, windows]

  tip: a similar value exists: 'komorebi'

For more information, try '--help'.

and in komorebi.json file:
"border_implementation": "Komorebi", works fine.

"border_implementation": "komorebi", doesn't work.

@azinsharaf commented on GitHub (Jul 21, 2024): no erorr in the logs. `komorebic border-implementation komorebi` output: `2024-07-21T17:08:28.232937Z INFO process_event{event=FocusChange(SystemForeground, Window { hwnd: 3542614 })}: komorebi::process_event: processed` `komorebic border-implementation Komorebi` output: ``` error: invalid value 'Komorebi' for '<STYLE>' [possible values: komorebi, windows] tip: a similar value exists: 'komorebi' For more information, try '--help'. ``` and in `komorebi.json` file: `"border_implementation": "Komorebi",` works fine. `"border_implementation": "komorebi",` doesn't work.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#434
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?