mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-01-11 14:40:25 +01:00
[BUG]: The window movement track of the move-to-monitor command is repeated #432
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MasouShizuka on GitHub (Jul 12, 2024).
Describe the bug
When using the
move-to-monitorcommand, the window's movement trajectory will repeat, as follows:https://github.com/user-attachments/assets/95f4421a-4660-4215-a194-4fd93dfedffc
However, when using the
send-to-monitorcommand, the window's motion trajectory is normal, as shown below:https://github.com/user-attachments/assets/726a2165-07b1-4f8c-b856-f78ee506d205
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The window's movement trajectory of the
move-to-monitorcommand is not repeated.Operating System
@LGUG2Z commented on GitHub (Jul 12, 2024):
Similar issues have been reported generally with cross-monitor moves. I think the best way forward here for now is to disable animations in general for any operations that move windows across monitor or workspace boundaries.
@MasouShizuka commented on GitHub (Jul 12, 2024):
This fix is not appropriate.
If the intermediate code encounters a
?and throws an error,ANIMATION_ENABLEDwill not be restored to its original value.@LGUG2Z commented on GitHub (Jul 12, 2024):
Updated the commit to follow the same pattern as when we temporarily disable borders:
50a279239a/komorebi/src/border_manager/mod.rs (L40)This ensures that the value set for
animationin the configuration will always be eventually consistent even if there are sporadic intermittent errors (subsequent successful calls that manipulateANIMATION_TEMPORARILY_DISABLEDwill reset the value to false).