starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[BUG]: Impossible to use komorebi-client due to transitive dependency features conflict #396

New Issue
Closed
opened 2026-01-05 14:50:21 +01:00 by adam · 2 comments
adam commented 2026-01-05 14:50:21 +01:00
Owner
Copy Link

Originally created by @edraze on GitHub (May 30, 2024).

Describe the bug
In the case when the komorebi-client is used in one project with some dependency that is transitively used crate parking_lot with feature send_guard, a compilation error occurs because komorebi-client transitively importing parking_lot with feature deadlock_detection and these features are mutually exclusive.

Error

error: the `send_guard` and `deadlock_detection` features cannot be used together
  --> \.cargo\registry\src\index.crates.io-6f17d22bba15001f\parking_lot-0.12.1\src\lib.rs:35:1
   |
35 | compile_error!("the `send_guard` and `deadlock_detection` features cannot be used together");
   |

To Reproduce

  1. add to dependencies crate bevy = "0.13"
  2. add to dependencies komorebi-client = { git = "https://github.com/LGUG2Z/komorebi", tag = "v0.1.25"})
  3. try to compile
  4. compilation error occurs

Expected behavior
Don't enforce deadlock_detection feature in komorebi for parking_lot dependency, make it customizable by crate futures.

Originally created by @edraze on GitHub (May 30, 2024). **Describe the bug** In the case when the `komorebi-client` is used in one project with some dependency that is transitively used crate `parking_lot` with feature `send_guard`, a compilation error occurs because `komorebi-client` transitively importing `parking_lot` with feature `deadlock_detection` and these features are mutually exclusive. **Error** ``` error: the `send_guard` and `deadlock_detection` features cannot be used together --> \.cargo\registry\src\index.crates.io-6f17d22bba15001f\parking_lot-0.12.1\src\lib.rs:35:1 | 35 | compile_error!("the `send_guard` and `deadlock_detection` features cannot be used together"); | ``` **To Reproduce** 1. add to dependencies crate `bevy = "0.13"` 2. add to dependencies `komorebi-client = { git = "https://github.com/LGUG2Z/komorebi", tag = "v0.1.25"})` 3. try to compile 4. compilation error occurs **Expected behavior** Don't enforce `deadlock_detection` feature in `komorebi` for `parking_lot` dependency, make it customizable by crate futures.
adam added the bug label 2026-01-05 14:50:21 +01:00
adam closed this issue 2026-01-05 14:50:21 +01:00
adam commented 2026-01-05 14:50:21 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (May 30, 2024):

Could you prepare a PR for this? 🙏

@LGUG2Z commented on GitHub (May 30, 2024): Could you prepare a PR for this? 🙏
adam commented 2026-01-05 14:50:22 +01:00
Author
Owner
Copy Link

@edraze commented on GitHub (May 30, 2024):

Sure, here https://github.com/LGUG2Z/komorebi/pull/859

@edraze commented on GitHub (May 30, 2024): Sure, here https://github.com/LGUG2Z/komorebi/pull/859
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#396
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?