Originally created by @edraze on GitHub (May 30, 2024).
Describe the bug
In the case when the komorebi-client is used in one project with some dependency that is transitively used crate parking_lot with feature send_guard, a compilation error occurs because komorebi-client transitively importing parking_lot with feature deadlock_detection and these features are mutually exclusive.
Error
error: the `send_guard` and `deadlock_detection` features cannot be used together
--> \.cargo\registry\src\index.crates.io-6f17d22bba15001f\parking_lot-0.12.1\src\lib.rs:35:1
|
35 | compile_error!("the `send_guard` and `deadlock_detection` features cannot be used together");
|
To Reproduce
add to dependencies crate bevy = "0.13"
add to dependencies komorebi-client = { git = "https://github.com/LGUG2Z/komorebi", tag = "v0.1.25"})
try to compile
compilation error occurs
Expected behavior
Don't enforce deadlock_detection feature in komorebi for parking_lot dependency, make it customizable by crate futures.
Originally created by @edraze on GitHub (May 30, 2024).
**Describe the bug**
In the case when the `komorebi-client` is used in one project with some dependency that is transitively used crate `parking_lot` with feature `send_guard`, a compilation error occurs because `komorebi-client` transitively importing `parking_lot` with feature `deadlock_detection` and these features are mutually exclusive.
**Error**
```
error: the `send_guard` and `deadlock_detection` features cannot be used together
--> \.cargo\registry\src\index.crates.io-6f17d22bba15001f\parking_lot-0.12.1\src\lib.rs:35:1
|
35 | compile_error!("the `send_guard` and `deadlock_detection` features cannot be used together");
|
```
**To Reproduce**
1. add to dependencies crate `bevy = "0.13"`
2. add to dependencies `komorebi-client = { git = "https://github.com/LGUG2Z/komorebi", tag = "v0.1.25"})`
3. try to compile
4. compilation error occurs
**Expected behavior**
Don't enforce `deadlock_detection` feature in `komorebi` for `parking_lot` dependency, make it customizable by crate futures.
adam
added the bug label 2026-01-05 14:50:21 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @edraze on GitHub (May 30, 2024).
Describe the bug
In the case when the
komorebi-clientis used in one project with some dependency that is transitively used crateparking_lotwith featuresend_guard, a compilation error occurs becausekomorebi-clienttransitively importingparking_lotwith featuredeadlock_detectionand these features are mutually exclusive.Error
To Reproduce
bevy = "0.13"komorebi-client = { git = "https://github.com/LGUG2Z/komorebi", tag = "v0.1.25"})Expected behavior
Don't enforce
deadlock_detectionfeature inkomorebiforparking_lotdependency, make it customizable by crate futures.@LGUG2Z commented on GitHub (May 30, 2024):
Could you prepare a PR for this? 🙏
@edraze commented on GitHub (May 30, 2024):
Sure, here https://github.com/LGUG2Z/komorebi/pull/859