mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-01-11 14:40:25 +01:00
[REGRESSION]: v0.1.26 does not work with virtualized monitors #389
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ianzhang366 on GitHub (May 24, 2024).
First of all, thanks for building this project!
Describe the bug
After upgraded to 0.1.26 from 0.1.25, komorebi stop working with error message:
To Reproduce
Steps to reproduce the behavior:
komorebi.exe --config="C:\Users\ianzhang\source\bin\komorebi.json" --ffmkomorebic logExpected behavior
Komorebi should start up properly.
Screenshots and Videos
Add screenshots and videos to help explain your problem.
Operating System
komorebic checkOutputAdditional context
config file:
with similar config the 0.1.25 output the following state:
@LGUG2Z commented on GitHub (May 24, 2024):
It looks like your display is not being detected anymore. Can you add this debug statement, run
cargo run --bin komorebiand share the output?You can add it under this line:
88684f991f/komorebi/src/windows_api.rs (L234)@LGUG2Z commented on GitHub (May 24, 2024):
Additional question, what hardware are you running this on? Is it on bare metal or a virtual machine?
@ianzhang366 commented on GitHub (May 24, 2024):
Hi @LGUG2Z I got the following:
It is on VM:
It was working on 0.1.25 tho.
@LGUG2Z commented on GitHub (May 24, 2024):
There were significant changes in the latest release to support persisting state across suspend/resume cycles and monitor disconnect/reconnect cycles; hardware IDs are now used to uniquely identify monitors across these cycles, and it looks like those hardware IDs might not be emulated in virtualized environments.
I'll look into this for the next release, it will probably require development here rather than in this repo: https://github.com/LGUG2Z/win32-display-data/
@ianzhang366 commented on GitHub (May 24, 2024):
cool, thanks.
I will rollback to 0.1.25 for now.
@LGUG2Z commented on GitHub (May 24, 2024):
@ianzhang366 I have tested the fix on a Win10 VM and all is good, please run from
da7a9394d8until the next release 🙏@ianzhang366 commented on GitHub (May 25, 2024):
@LGUG2Z Just I run it, it works great! thanks for the fix and prompt help!