mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-01-11 14:40:25 +01:00
[BUG]: Alt + (H/J/K/L) can still be used in monocle mode #372
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rp1231 on GitHub (May 11, 2024).
Describe the bug
Alt + (H/J/K/L) can still be used in monocle mode.
This produces visual artifacts of the window being focused.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Switch window focus keyboard shortcuts should be disabled while the monocle is enabled.
Screenshots and Videos
Add screenshots and videos to help explain your problem.
Operating System
OS Name: Microsoft Windows 11 Home
OS Version: 10.0.22631 N/A Build 22631
Additional context
Using the default keyboard shortcuts generated by komorebi.
@rp1231 commented on GitHub (May 15, 2024):
@LGUG2Z Thanks for implementing this but I am facing a problem.
Would it be possible to allow Alt+(H/J/K/L) for switching to windows on a different monitor, but just disable it for switching to windows on the same workspace?
Thanks
@LGUG2Z commented on GitHub (May 15, 2024):
I knew there was a reason this wasn't implemented in the first place, I just couldn't think of it 😅
I'm going to revert this commit; ALT+HJKL should work even in monocle mode, I think this is a case where the user needs to adapt to the software vs the software adapting to the user.
@rp1231 commented on GitHub (May 17, 2024):
@LGUG2Z Thanks for implementing this.
But I was wondering if the monocle window should lose it's border when it's unfocused?
Right now, when I shift the focus to a window on my other monitor, the monocle window retains its border making it slightly confusing as to which window is focused.
Would love to hear your thoughts on this.
@LGUG2Z commented on GitHub (May 17, 2024):
I'll double check this on the master branch tomorrow; I don't think what you're describing should be an issue with the latest changes 🤞
@LGUG2Z commented on GitHub (May 17, 2024):
Fixed this and a bunch of other monocle-related regressions ^
@rp1231 commented on GitHub (May 17, 2024):
Thanks this works great!
One last minor thing would be that If I
A flash of the windows obfuscated by the monocle will be visible for a fraction of a second.
Is this something that can be fixed?
@LGUG2Z commented on GitHub (May 18, 2024):
Fixed this and another bug monocle-related bug ^
@rp1231 commented on GitHub (May 18, 2024):
Thanks, Works perfectly now!
@rp1231 commented on GitHub (May 18, 2024):
@LGUG2Z It works perfectly when switching from window to a monocle window.
But the visual artifacts still occur when switching from a workspace to a monocle workspace.
@rp1231 commented on GitHub (May 18, 2024):
Also one more bug:
When refocusing to a monocle from another window(on another monitor), only the border seems to focus the monocle not the actual window focus.
Hope I've explained that properly.
@LGUG2Z commented on GitHub (May 18, 2024):
The rendering bug should be fixed, I will take a look at the focus one a little later
@LGUG2Z commented on GitHub (May 18, 2024):
Focus is also fixed now (force-pushed the same commit)
@rp1231 commented on GitHub (May 19, 2024):
Thanks, This commit seems to have solved the focusing and rendering problems.