starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[BUG]: Toggle Pause Off not coming through in Named Pipe (to YASB) #342

New Issue
Closed
opened 2026-01-05 14:49:51 +01:00 by adam · 2 comments
adam commented 2026-01-05 14:49:51 +01:00
Owner
Copy Link

Originally created by @jpmiller25 on GitHub (Apr 15, 2024).

Diagnosing some issues in the YASB integration, I found that it seems the TogglePause event is coming through on the named pipe only when toggling pause ON. When toggling pause OFF, there is no event, so YASB is not picking it up.
I'm completely lost in rust, just barely fluent in Python, so I'm not sure how to check from komorebi side. If yall can confirm the pipe is working from komorebi, just let me know I'll go back to messing with yasb :)

To Reproduce
I added a logger in the YASB event listener on the named pipe. I'm logging all buffer reads (win32pipe.PeekNamedPipe()) to make sure I'm getting the raw pipe, rather than anything after YASB code filters anything out. The event is not coming through when toggling Pause OFF.

Expected behavior
Pipe events when toggling pause on and off

Operating System
OS Name: Microsoft Windows 10 Business
OS Version: 10.0.19045 N/A Build 19045

komorebic check Output

KOMOREBI_CONFIG_HOME detected: C:\Users\jmiller\.config\komorebi

Looking for configuration files in C:\Users\jmiller\.config\komorebi

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\jmiller\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag

Additional context
Running 0.1.24 release, latest main branch of darth/yasb.

Originally created by @jpmiller25 on GitHub (Apr 15, 2024). Diagnosing some issues in the YASB integration, I found that it seems the TogglePause event is coming through on the named pipe only when toggling pause ON. When toggling pause OFF, there is no event, so YASB is not picking it up. I'm completely lost in rust, just barely fluent in Python, so I'm not sure how to check from komorebi side. If yall can confirm the pipe is working from komorebi, just let me know I'll go back to messing with yasb :) **To Reproduce** I added a logger in the YASB event listener on the named pipe. I'm logging all buffer reads (win32pipe.PeekNamedPipe()) to make sure I'm getting the raw pipe, rather than anything after YASB code filters anything out. The event is not coming through when toggling Pause OFF. **Expected behavior** Pipe events when toggling pause on and off **Operating System** OS Name: Microsoft Windows 10 Business OS Version: 10.0.19045 N/A Build 19045 **`komorebic check` Output** ``` KOMOREBI_CONFIG_HOME detected: C:\Users\jmiller\.config\komorebi Looking for configuration files in C:\Users\jmiller\.config\komorebi Found komorebi.json; this file can be passed to the start command with the --config flag Found C:\Users\jmiller\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag ``` **Additional context** Running 0.1.24 release, latest main branch of darth/yasb.
adam added the bug label 2026-01-05 14:49:51 +01:00
adam closed this issue 2026-01-05 14:49:51 +01:00
adam commented 2026-01-05 14:49:52 +01:00
Author
Owner
Copy Link

@1096015776 commented on GitHub (May 11, 2024):

yes, i use your yasb , in python version, i can focus windows,then the active workspace can change.I read rust version,I found it not work when add KomorebiFocusNamedWorkspace listener

@1096015776 commented on GitHub (May 11, 2024): yes, i use your yasb , in python version, i can focus windows,then the active workspace can change.I read rust version,I found it not work when add KomorebiFocusNamedWorkspace listener
adam commented 2026-01-05 14:49:52 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (May 12, 2024):

6a1ed3bcaa (diff-704dbf9c754ba46b11956db31592bc56081bdbdcd69cac5b9c827a9d446866eeR1320)

Fixed here, the untile event now gets sent properly 🎉

@LGUG2Z commented on GitHub (May 12, 2024): https://github.com/LGUG2Z/komorebi/commit/6a1ed3bcaa8d1f6e75535778fc5bd51d9cc3c019#diff-704dbf9c754ba46b11956db31592bc56081bdbdcd69cac5b9c827a9d446866eeR1320 Fixed here, the untile event now gets sent properly 🎉
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#342
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?