[CODE] rename the "activate" parameter SetWindowPos wrappers #333

New Issue

2026-01-05T14:49:47+01:00

adam commented

2026-01-05 14:49:47 +01:00

Originally created by @raggi on GitHub (Apr 13, 2024).

The activate parameter doesn't actually activate the window. For example this is used via the Border::set_position wrapper to show the window if it's hidden.

Similarly the main wrapper always sets the NO_ACTIVATE flag. Window activation is a little funky, because it's slightly separate from focus. Generally we're not interested in activating windows when we're not focusing them, and so really this is always just show, so we can name it "show" instead.

Originally created by @raggi on GitHub (Apr 13, 2024). The activate parameter doesn't actually activate the window. For example this is used via the Border::set_position wrapper to show the window if it's hidden. Similarly the main wrapper always sets the NO_ACTIVATE flag. Window activation is a little funky, because it's slightly separate from focus. Generally we're not interested in activating windows when we're not focusing them, and so really this is always just show, so we can name it "show" instead.

adam closed this issue

2026-01-05 14:49:47 +01:00

adam referenced this issue

2026-01-05 14:53:15 +01:00

[PR #333] [MERGED] chore(deps): bump sysinfo from 0.27.2 to 0.27.3 #869

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/komorebi#333