starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[CODE] rename the "activate" parameter SetWindowPos wrappers #333

New Issue
Closed
opened 2026-01-05 14:49:47 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:49:47 +01:00
Owner
Copy Link

Originally created by @raggi on GitHub (Apr 13, 2024).

The activate parameter doesn't actually activate the window. For example this is used via the Border::set_position wrapper to show the window if it's hidden.

Similarly the main wrapper always sets the NO_ACTIVATE flag. Window activation is a little funky, because it's slightly separate from focus. Generally we're not interested in activating windows when we're not focusing them, and so really this is always just show, so we can name it "show" instead.

Originally created by @raggi on GitHub (Apr 13, 2024). The activate parameter doesn't actually activate the window. For example this is used via the Border::set_position wrapper to show the window if it's hidden. Similarly the main wrapper always sets the NO_ACTIVATE flag. Window activation is a little funky, because it's slightly separate from focus. Generally we're not interested in activating windows when we're not focusing them, and so really this is always just show, so we can name it "show" instead.
adam closed this issue 2026-01-05 14:49:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#333
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?