starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[BUG]: Layout breaks if workspace layout is not specified in config #330

New Issue
Closed
opened 2026-01-05 14:49:46 +01:00 by adam · 2 comments
adam commented 2026-01-05 14:49:46 +01:00
Owner
Copy Link

Originally created by @michaelruigrok on GitHub (Apr 11, 2024).

Describe the bug
According to the config reference, a workspace's layout defaults to the BSP layout. However, if layout is unset, that workspace's layout breaks, causing komorebi to crash.

To Reproduce
Steps to reproduce the behavior:

  1. Set monitors config as the following:
  "monitors": [
    {
      "workspaces": [
        {
          "name": "I",
          "layout": "BSP"
        },
        {
          "name": "II"
        }
      ]
    }
  ]

  1. Swap to workspace II and create a window

  2. Try and toggle floating, move the window, etc

  3. See that the window is not behaving properly

  4. run komorebic stop.

  5. Open up process manager and Note that the komorebi process continues to run.

Expected behavior
The workspace should correctly have the BSP layout applied.

Operating System

OS Name:                   Microsoft Windows 11 Pro
OS Version:                10.0.22631 N/A Build 22631

komorebic check Output

KOMOREBI_CONFIG_HOME detected: C:\Users\ruig01/.config/komorebi

Looking for configuration files in C:\Users\ruig01/.config/komorebi

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\ruig01\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag

Additional context
N/A

Originally created by @michaelruigrok on GitHub (Apr 11, 2024). **Describe the bug** According to the [config reference](https://komorebi.lgug2z.com/schema#headingmonitors_items_workspaces_items_layout), a workspace's layout defaults to the BSP layout. However, if `layout` is unset, that workspace's layout breaks, causing komorebi to crash. **To Reproduce** Steps to reproduce the behavior: 1. Set `monitors` config as the following: ```json "monitors": [ { "workspaces": [ { "name": "I", "layout": "BSP" }, { "name": "II" } ] } ] ``` 2. Swap to workspace II and create a window 3. Try and toggle floating, move the window, etc 4. See that the window is not behaving properly 5. run `komorebic stop`. 6. Open up process manager and Note that the `komorebi` process continues to run. **Expected behavior** The workspace should correctly have the BSP layout applied. **Operating System** ``` OS Name: Microsoft Windows 11 Pro OS Version: 10.0.22631 N/A Build 22631 ``` **`komorebic check` Output** ``` KOMOREBI_CONFIG_HOME detected: C:\Users\ruig01/.config/komorebi Looking for configuration files in C:\Users\ruig01/.config/komorebi Found komorebi.json; this file can be passed to the start command with the --config flag Found C:\Users\ruig01\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag ``` **Additional context** N/A
adam added the bug label 2026-01-05 14:49:46 +01:00
adam closed this issue 2026-01-05 14:49:46 +01:00
adam commented 2026-01-05 14:49:47 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Apr 11, 2024):

This is actually intended behaviour and the default referred to in the docs applies when a new workspace is created on the fly (is. not defined in the static config file but created using a focus-workspace call).

Passing a None/null value explicitly, or implicitly by omitting the layout key, turns the workspace into a floating workspace.

More info on this:

Configure a Floating Workspace | Tutorial | Komorebi v0.1.19+ | Windows 11 Tiling Window Manager
https://youtu.be/tzSkCYxrhH8

@LGUG2Z commented on GitHub (Apr 11, 2024): This is actually intended behaviour and the default referred to in the docs applies when a new workspace is created on the fly (is. not defined in the static config file but created using a `focus-workspace` call). Passing a None/null value explicitly, or implicitly by omitting the layout key, turns the workspace into a floating workspace. More info on this: Configure a Floating Workspace | Tutorial | Komorebi v0.1.19+ | Windows 11 Tiling Window Manager https://youtu.be/tzSkCYxrhH8
adam commented 2026-01-05 14:49:47 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Apr 11, 2024):

Note to self to update the wording on the docs and add a page on floating workspaces to the mkdocs site

@LGUG2Z commented on GitHub (Apr 11, 2024): Note to self to update the wording on the docs and add a page on floating workspaces to the mkdocs site
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#330
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?