starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[FEAT]: Stackbar #301

New Issue
Closed
opened 2026-01-05 14:49:36 +01:00 by adam · 3 comments
adam commented 2026-01-05 14:49:36 +01:00
Owner
Copy Link

Originally created by @LGUG2Z on GitHub (Feb 24, 2024).

Originally assigned to: @LGUG2Z on GitHub.

Is your feature request related to a problem? Please describe.
I'd like visual indicators of which windows are in a given stack in the form of a stackbar.

Describe the solution you'd like
When a container has more than one window, a stackbar appears on top of the windows.

Describe alternatives you've considered
Different border colours for multi-window containers are implemented, but this would be even more helpful for understanding what is in a stack at any given time, especially when coming back a running computer after some time away.

Additional context
This has been implemented by @eythaann in their fork, though there is considerable drift in how the code is structured in the fork.

image

I believe the relevant commits are these:

953703e5f9
68728c3fb6
75d5802640
e8b7ec4161

Originally created by @LGUG2Z on GitHub (Feb 24, 2024). Originally assigned to: @LGUG2Z on GitHub. **Is your feature request related to a problem? Please describe.** I'd like visual indicators of which windows are in a given stack in the form of a stackbar. **Describe the solution you'd like** When a container has more than one window, a stackbar appears on top of the windows. **Describe alternatives you've considered** Different border colours for multi-window containers are implemented, but this would be even more helpful for understanding what is in a stack at any given time, especially when coming back a running computer after some time away. **Additional context** This has been implemented by @eythaann in their fork, though there is considerable drift in how the code is structured in the fork. ![image](https://github.com/LGUG2Z/komorebi/assets/13164844/35618d09-4124-4e98-af38-71dcbd80c275) I believe the relevant commits are these: https://github.com/eythaann/komorebi/commit/953703e5f98045062e723b16c5f7abc323fe4150 https://github.com/eythaann/komorebi/commit/68728c3fb675db0f0baed6228fbcd7d14f63d481 https://github.com/eythaann/komorebi/commit/75d580264070e04efa5c133214adc53eb8e702ac https://github.com/eythaann/komorebi/commit/e8b7ec4161c63b662ac7779e823a87c650ae79db
adam added the enhancement label 2026-01-05 14:49:36 +01:00
adam closed this issue 2026-01-05 14:49:36 +01:00
adam commented 2026-01-05 14:49:36 +01:00
Author
Owner
Copy Link

@eythaann commented on GitHub (Feb 25, 2024):

@LGUG2Z Basically is easy to do a PR but I have to do it manually, using cherry pick is imposible in this case, but I love follow encapsulation principle so copying the top_bar.rs file is the most part of the feature, also testing it I have a specifit issue:

  1. the most important is that for some reason the top bar does not work in the release version I had change the optimizations value to 1, so it works now. the reason is that the creation method the HWND returns 0 so the window was not created. (I really don't know why this happen with default optimization level 3 so in my fork I changed it to 1)
@eythaann commented on GitHub (Feb 25, 2024): @LGUG2Z Basically is easy to do a PR but I have to do it manually, using cherry pick is imposible in this case, but I love follow encapsulation principle so copying the top_bar.rs file is the most part of the feature, also testing it I have a specifit issue: 1. the most important is that for some reason the top bar does not work in the release version I had change the optimizations value to 1, so it works now. the reason is that the creation method the HWND returns 0 so the window was not created. (I really don't know why this happen with default optimization level 3 so in my fork I changed it to 1)
adam commented 2026-01-05 14:49:36 +01:00
Author
Owner
Copy Link

@NireBryce commented on GitHub (Mar 1, 2024):

I missed this title in the search, so I accidentally duped it

reposting the zellij stacked titles screenshot (left side) because it might be a useful reference

309364288-1ca09134-c1eb-47b9-9d70-2d19d1425564

@NireBryce commented on GitHub (Mar 1, 2024): I missed this title in the search, so I accidentally duped it reposting the `zellij` stacked titles screenshot (left side) because it might be a useful reference ![309364288-1ca09134-c1eb-47b9-9d70-2d19d1425564](https://github.com/LGUG2Z/komorebi/assets/24237095/2660f15c-2a0f-4fde-95d9-5b335a07a3f2)
adam commented 2026-01-05 14:49:36 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Mar 1, 2024):

@NireBryce You're welcome to play around with what is on the branch here: https://github.com/LGUG2Z/komorebi/tree/feature/stackbar

It's functional, but I'm sure there are some edge cases waiting to be found. Here is the config snippet (top-level in komorebi.json) that I am using when I work on that branch:

{
  "stackbar": {
    "height": 40,
    "mode": "OnStack",
    "tabs": {
      "width": 300,
      "focused_text": "#00a542",
      "unfocused_text": "#b3b3b3",
      "background": "#141414",
    }
  }
}
@LGUG2Z commented on GitHub (Mar 1, 2024): @NireBryce You're welcome to play around with what is on the branch here: https://github.com/LGUG2Z/komorebi/tree/feature/stackbar It's functional, but I'm sure there are some edge cases waiting to be found. Here is the config snippet (top-level in `komorebi.json`) that I am using when I work on that branch: ```jsonc { "stackbar": { "height": 40, "mode": "OnStack", "tabs": { "width": 300, "focused_text": "#00a542", "unfocused_text": "#b3b3b3", "background": "#141414", } } } ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#301
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?