mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-01-11 14:40:25 +01:00
Crash on startup #3
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @naoey on GitHub (Aug 13, 2021).
Originally assigned to: @LGUG2Z on GitHub.
Hello!
Just wanted to say thank you for building this as I've recently switched over to working on Windows and have sorely missed having a WM like this coming from using yabai on macOS. I've gone through the setup as described in the readme but haven't been able to get komorebi up and running yet.
I attempted to get it started as described in the instructions:
However nothing happens after this and on running
komorebi.exe stateI see this output:Attempting to run
komorebi.exedirectly there appears to be an exception on startup causing the process to terminate:This is running on the current latest master @
c15f1e1.@LGUG2Z commented on GitHub (Aug 13, 2021):
Thank you for this detailed report! Are you using multiple monitors by any chance? It looks like this is a bug that I didn't catch because I only use one monitor 😅.
I think you're hitting this call which tries to ensure that Windows are associated with the correct monitor.
Looking a bit further in the stack trace it seems like the issue is with this line which was recently introduced as part of the resizing feature. I think that wrapping this in an
if let Some()block should resolve the issue, asremoveonVecdoes indeed panic whenindexis out of bounds instead of returning anOption<T>likeremoveonVecDeque.I'll @ you in this issue when I'm able to push these changes to a branch for you to try out later today 🤞.
@LGUG2Z commented on GitHub (Aug 13, 2021):
@naoey https://github.com/LGUG2Z/komorebi/tree/hotfix/multi-monitor-startup-panic
@naoey commented on GitHub (Aug 14, 2021):
Yes, I do use multiple monitors. Tried this branch out and it started up successfully 👍
Another couple of questions that I had:
@LGUG2Z commented on GitHub (Aug 14, 2021):
Right now the AHK script has to be run manually (either by double clicking it in
explorer.exeor running something likeStart-Process autohotkey.exe komorebi.ahk -WindowStyle hiddenin PowerShell), but it's a good idea to look for it in a common directory (probably~/.komorebi.ahkand then execute it immediately afterkomorebi.exestarts listening for messages on its socket. I will open a separate issue to track this.There is currently no option that allows for a workspace without tiling. I will open a a separate ticket to track this.
Workspaces in
komorebiare unrelated to Windows Virtual Desktops; they are implemented as a thin layer on top of the existing DWM by showing and hiding windows programmatically. You have a few options for workspace creation right now:This is usually run at the start of a config file to ensure the minimum number of workspaces that you want to work with on each monitor.
This will try to switch to the given workspace index on the active monitor, and if it doesn't exist, it will be created, along with any other required workspace indices on the way. For example, if you only have one workspace (
0) on the monitor, and you try to focus workspace index3, workspaces1and2will also be created in the process.I think it's a good idea to have a command that will just append a new workspace on the currently focused monitor (similar to the Win+Ctrl+D behaviour); I'll open a separate ticket to track this.
@LGUG2Z commented on GitHub (Aug 14, 2021):
@naoey The three enhancements on the referenced issues have been implemented and are on the
masterbranch, you can check the commit messages for the new commands that are now available to create/append a new workspace and to configure or toggle tiling on a workspace. 🎉@naoey commented on GitHub (Aug 16, 2021):
That was fast! 😄
Thanks a bunch I'll give it a spin later today.
Ah that's where my confusion came from, as I was looking to try and disable tiling on specific Windows 10 virtual desktops. Would love to have that as a feature sometime in the future!