starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[BUG]: Kill whkd on komorebi stop? #289

New Issue
Closed
opened 2026-01-05 14:49:31 +01:00 by adam · 2 comments
adam commented 2026-01-05 14:49:31 +01:00
Owner
Copy Link

Originally created by @melMass on GitHub (Feb 1, 2024).

Describe the bug
As I'm working on an eventual PR for whkd I realised that komorebi stop was not killing whkd is specified on start.

Expected behavior
Kill whkd if the flag was used in the cli, not if ran independantly

Originally created by @melMass on GitHub (Feb 1, 2024). **Describe the bug** As I'm working on an eventual PR for whkd I realised that `komorebi stop` was not killing whkd is specified on start. **Expected behavior** Kill whkd if the flag was used in the cli, not if ran independantly
adam added the bug label 2026-01-05 14:49:31 +01:00
adam closed this issue 2026-01-05 14:49:31 +01:00
adam commented 2026-01-05 14:49:31 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Feb 1, 2024):

https://github.com/LGUG2Z/komorebi/blob/v0.1.19/komorebic/src/main.rs#L635

https://lgug2z.github.io/komorebi/cli/stop.html

If you don't want to add the --whkd flag when you type the command I suggest aliasing the komorebic stop command to komorebic stop --whkd in your $PROFILE as the window manager itself doesn't keep track of arguments passed to the start command.

@LGUG2Z commented on GitHub (Feb 1, 2024): https://github.com/LGUG2Z/komorebi/blob/v0.1.19/komorebic/src/main.rs#L635 https://lgug2z.github.io/komorebi/cli/stop.html If you don't want to add the `--whkd` flag when you type the command I suggest aliasing the `komorebic stop` command to `komorebic stop --whkd` in your `$PROFILE` as the window manager itself doesn't keep track of arguments passed to the `start` command.
adam commented 2026-01-05 14:49:31 +01:00
Author
Owner
Copy Link

@melMass commented on GitHub (Feb 1, 2024):

Nice I do use the flag on start but did not notice it existed on stop too! Perfect thanks

@melMass commented on GitHub (Feb 1, 2024): Nice I do use the flag on start but did not notice it existed on stop too! Perfect thanks
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#289
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?