mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-01-11 14:40:25 +01:00
[BUG]: Komorobi is unable to load the static config #280
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @claudio4 on GitHub (Jan 12, 2024).
Describe the bug
Komorobi refuses to load the static config file.
If komorebi is run without arguments it just ignores the config file, as if it does not exists. If I use the
--configflag to force it to load the config file I get this error:I AM sure that the file does indeed exists as I can
catit just fine.To Reproduce
Steps to reproduce the behavior:
KOMOREBI_CONFIG_HOME.komorebi --config "PATH\TO\komorebi.json"alternatvely usingkomorebic start --config "PATH\TO\komorebi.json"has the same effect, but it obscures the error message.Expected behavior
Komorobi should read the config file.
Operating System
komorebic checkOutputAdditional context
This happens with or without
whkdorahkinstalled. I have sucessfully replicated in a brand new Windows Sandbox (a.k.a a VM with my same version of Windows).Probably related to #625, but that issue also talks about whkd, while this one is standalone to komorebi.
@azinsharaf commented on GitHub (Jan 13, 2024):
i agree that returning
No komorebi configuration found in ...message is an issue. but beside that if you force to use it in-cit should pick it up.i run it this way and it works:
komorebic start -c "$Env:USERPROFILE\.config\komorebi\komorebi.json" --whkdas a side note, storing it in .config makes the dot files management easier. it is just a matter of personal preference.
@claudio4 commented on GitHub (Jan 13, 2024):
It should but it does not.
For me it produces this error:
Before runnig the command above I have moved my komorebi folder to
.configto prove that it is not some appdata werideness.@azinsharaf commented on GitHub (Jan 13, 2024):
can you post your json file?
@claudio4 commented on GitHub (Jan 13, 2024):
Yes, ofcourse,
@azinsharaf commented on GitHub (Jan 13, 2024):
the syntax and schema look correct. Do you have
applications.yamlin the provided path?@LGUG2Z commented on GitHub (Jan 13, 2024):
You need to use forward slashes in paths in the JSON files ^
@claudio4 commented on GitHub (Jan 13, 2024):
I was about to say yes, then double checked and... No 🤦. For whatever the reason (probably me being very dumb) my file was called
applications.ymlinstead ofapplications.yaml. So yeah, that one is on me. I'm very sorry.Nonetheless, I think that improving the error message for a missing applications.yaml could be a wise move to prevent more people f*nking up like I did.
@azinsharaf commented on GitHub (Jan 14, 2024):
glad it works.
i agree that the messages contents can be improved.
@LGUG2Z commented on GitHub (Jan 15, 2024):
I have updated the
komorebic checkcommand to validate the existence of the file - this will be part of the next release.@goyalyashpal commented on GitHub (Jan 29, 2024):
hehe, i had no plan to use whkd, i faced that issue without whkd first, but as it's said that komorebi requires external thing to manage input etc, and it didn't seem working either. that's why i installed whkd as a fallback - "oh, i guess it requires that too to work"
@goyalyashpal commented on GitHub (Apr 3, 2024):
it was this one right?
https://github.com/LGUG2Z/komorebi/releases/tag/v0.1.20