mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-01-11 14:40:25 +01:00
[FEAT]: Ignore/Float Fixed sized windows #259
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nascentt on GitHub (Nov 16, 2023).
I find Komorebi keeps tiling and resizing fixed sized windows, including native windows like the Windows File Copy/Delete dialog. It'd be great if Komorebi could just be told to float/ignore all Fixed sized windows as this would save needing to set custom window rules for every single fixed window's class
@LGUG2Z commented on GitHub (Nov 17, 2023):
These types of windows have been covered in komorebi-application-specific-configuration for some time now.
I think the best way to move forward with this report is to share your configuration files, share the command you're using the start the window manager, and a video that shows you starting the window manager from scratch and replicating the issue (ie. a copy dialog or other native windows being managed when they shouldn't) as a minimal reproduction case that we can try to reproduce on our own machines and see if this is a a documentation issue or something deeper in the codebase that is being triggered by specific configuration options that may not be playing well with each other.
@nascentt commented on GitHub (Nov 18, 2023):
Yup, that is the configuration file I use on top of a default installation, but it didn't work correctly.
However I redid all my steps again and followed the quick start readme again and I think I have igured out the issue.
The installed version of komorebi is no different to the portable one - it doesnt load config using the start menu shortcut. Komorebi expects you to load the config with the comamndline but the installed version has a startmenu shortcut that doesnt load the config.
So going back to the portable app was the solution because komorebi needs fully manual configuration and launching.
I'd strongly recommend the installer based version made more user friendly. The installer should pull applications.yaml, and generate komorebi.json, and the start menu shortcut should be created with the path "C:\Program Files\komorebi\bin\komorebi.exe" --config="C:\Users\username\komorebi.json" I'll log a new feature for this to avoid contimination.
I'll keep this feature reuest open, as despite figuring out why komorebi wasnt loading the config and having the specific window caught as floating, it doesnt solve all the other fixed window dialogs that get caught by komorebi. i shouldnt need to manually hand configure them all. all fixed windows should be ignored by komorebi, wether thats an option in komorebi.json or however it should be set.