starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[BUG]: komorebic start no longer works with no arguments in 0.1.18 #229

New Issue
Closed
opened 2026-01-05 14:49:08 +01:00 by adam · 4 comments
adam commented 2026-01-05 14:49:08 +01:00
Owner
Copy Link

Originally created by @notkvwu on GitHub (Jul 15, 2023).

Originally assigned to: @LGUG2Z on GitHub.

Describe the bug
komorebic start no longer works with no arguments

To Reproduce
Run komorebic start with no arguments

Expected behavior
Komorebi starts as it always has

Operating System

OS Name:                   Microsoft Windows 11 Enterprise
OS Version:                10.0.22621 N/A Build 22621

komorebic check Output
Komorebi does not start

Additional context
It looks like komorebi tries to execute

Start-Process komorebi.exe -ArgumentList  -WindowStyle hidden

But this is not valid powershell since ArgumentList must have a value. I assume it was introduced in this commit 4510cccc3e.

I know the guides have switched to komorebic start --await-configuration, which works perfectly fine. But I thought maybe this was unintended, so I thought I'd create a bug report.

Originally created by @notkvwu on GitHub (Jul 15, 2023). Originally assigned to: @LGUG2Z on GitHub. **Describe the bug** `komorebic start` no longer works with no arguments **To Reproduce** Run `komorebic start` with no arguments **Expected behavior** Komorebi starts as it always has **Operating System** ``` OS Name: Microsoft Windows 11 Enterprise OS Version: 10.0.22621 N/A Build 22621 ``` **`komorebic check` Output** Komorebi does not start **Additional context** It looks like komorebi tries to execute ``` Start-Process komorebi.exe -ArgumentList -WindowStyle hidden ``` But this is not valid powershell since `ArgumentList` must have a value. I assume it was introduced in this commit https://github.com/LGUG2Z/komorebi/commit/4510cccc3e7efb548e48ceb69ae5a20768ade4aa. I know the guides have switched to `komorebic start --await-configuration`, which works perfectly fine. But I thought maybe this was unintended, so I thought I'd create a bug report.
adam added the bug label 2026-01-05 14:49:08 +01:00
adam closed this issue 2026-01-05 14:49:09 +01:00
adam commented 2026-01-05 14:49:09 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Jul 15, 2023):

This is definitely a regression ^

Will make sure this is fixed going into the next release. In the meantime, people who specifically still want to start the program like this can run Start-Process komorebi.exe -WindowStyle hidden instead of komorebic start.

@LGUG2Z commented on GitHub (Jul 15, 2023): This is definitely a regression ^ Will make sure this is fixed going into the next release. In the meantime, people who specifically still want to start the program like this can run `Start-Process komorebi.exe -WindowStyle hidden` instead of `komorebic start`.
adam commented 2026-01-05 14:49:09 +01:00
Author
Owner
Copy Link

@davorklju commented on GitHub (Sep 11, 2023):

Hey new user.
Does running the above command respect the komorebi_config_dir env variable? On my end it's staring up with the default config.
Just want to make sure if it's an issue on my end.

@davorklju commented on GitHub (Sep 11, 2023): Hey new user. Does running the above command respect the komorebi_config_dir env variable? On my end it's staring up with the default config. Just want to make sure if it's an issue on my end.
adam commented 2026-01-05 14:49:09 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Sep 11, 2023):

Running the above command does respect the config environment variable, as this is looked up once komorebi has started, not during the PS command execution. I'm actually working on a fix for this regression as we speak. 😅

@LGUG2Z commented on GitHub (Sep 11, 2023): Running the above command does respect the config environment variable, as this is looked up once `komorebi` has started, not during the PS command execution. I'm actually working on a fix for this regression as we speak. 😅
adam commented 2026-01-05 14:49:09 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Sep 11, 2023):

@notkvwu Sorry this took so long! It is on master now and will be in the next release.

@LGUG2Z commented on GitHub (Sep 11, 2023): @notkvwu Sorry this took so long! It is on `master` now and will be in the next release.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#229
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?