starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

Animations Request #224

New Issue
Closed
opened 2026-01-05 14:49:06 +01:00 by adam · 11 comments
adam commented 2026-01-05 14:49:06 +01:00
Owner
Copy Link

Originally created by @sho-orty on GitHub (Jun 19, 2023).

Is there any way for komorebi to manipulate animations while moving the windows like picom and hyprland?

Originally created by @sho-orty on GitHub (Jun 19, 2023). Is there any way for komorebi to manipulate animations while moving the windows like picom and hyprland?
adam added the enhancement label 2026-01-05 14:49:06 +01:00
adam closed this issue 2026-01-05 14:49:06 +01:00
adam commented 2026-01-05 14:49:06 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Jun 20, 2023):

This isn't something that I personally have any interest in working on, but I will leave the issue open in the hopes that if anyone really wants this enough, they will built it 👌

@LGUG2Z commented on GitHub (Jun 20, 2023): This isn't something that I personally have any interest in working on, but I will leave the issue open in the hopes that if anyone really wants this enough, they will built it 👌
adam commented 2026-01-05 14:49:07 +01:00
Author
Owner
Copy Link

@thearturca commented on GitHub (Sep 29, 2023):

Hello there!
I'm currently working on animation. Here demo (sorry have to split video for 2 parts because of the limitation of github).
Currently have 2 major problem with that as you can see in my demo.

  1. Border window doesn't update properly.
  2. Goggle chrome window brokes if you will move it during animation in progress

Part1

https://github.com/LGUG2Z/komorebi/assets/74871489/8955424f-1178-4be2-a1a9-f37bd35bd112

Part2

https://github.com/LGUG2Z/komorebi/assets/74871489/4fb249b1-6c37-4c74-8d93-07748a7bc289

I've implemented commands to enable/disable animation, set the duration of animation in ms, set ease function which will be applied to animation.
I didn't publish my fork yet. Trying to fix Google chrome window 🙂

UPD

I'm new to rust and low level programming. Usually write some server-side typescript. So it's may took long time to finish my implementation

@thearturca commented on GitHub (Sep 29, 2023): Hello there! I'm currently working on animation. Here demo (sorry have to split video for 2 parts because of the limitation of github). Currently have 2 major problem with that as you can see in my demo. 1. Border window doesn't update properly. 2. Goggle chrome window brokes if you will move it during animation in progress ### Part1 https://github.com/LGUG2Z/komorebi/assets/74871489/8955424f-1178-4be2-a1a9-f37bd35bd112 ### Part2 https://github.com/LGUG2Z/komorebi/assets/74871489/4fb249b1-6c37-4c74-8d93-07748a7bc289 I've implemented commands to enable/disable animation, set the duration of animation in ms, set ease function which will be applied to animation. I didn't publish my fork yet. Trying to fix Google chrome window 🙂 ### UPD I'm new to rust and low level programming. Usually write some server-side typescript. So it's may took long time to finish my implementation
adam commented 2026-01-05 14:49:07 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Sep 29, 2023):

@thearturca This is so amazing! I can't wait to try this out! Please give me an @ ping when your fork is published and I'll see if I can help with the border window updates 🤞

@LGUG2Z commented on GitHub (Sep 29, 2023): @thearturca This is so amazing! I can't wait to try this out! Please give me an @ ping when your fork is published and I'll see if I can help with the border window updates 🤞
adam commented 2026-01-05 14:49:07 +01:00
Author
Owner
Copy Link

@thearturca commented on GitHub (Oct 5, 2023):

@LGUG2Z I published my fork. Didn't solve issue with Google Chrome window. Maybe you have some thought about it.
My explanations in last commit and in code via comments.

https://github.com/thearturca/komorebi/tree/animate-window-move

@thearturca commented on GitHub (Oct 5, 2023): @LGUG2Z I published my fork. Didn't solve issue with Google Chrome window. Maybe you have some thought about it. My explanations in last commit and in code via comments. https://github.com/thearturca/komorebi/tree/animate-window-move
adam commented 2026-01-05 14:49:07 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Nov 25, 2023):

@thearturca I made some good progress on fixing the border issues today; can you open a PR from your branch to the main repo so that I can push some changes for you to try out?

@LGUG2Z commented on GitHub (Nov 25, 2023): @thearturca I made some good progress on fixing the border issues today; can you open a PR from your branch to the main repo so that I can push some changes for you to try out?
adam commented 2026-01-05 14:49:07 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Nov 25, 2023):

I was able to add a new origin to your fork and push it back here @thearturca

https://github.com/LGUG2Z/komorebi/tree/animate-window-move

I've rebased with the latest release, added a new commit on top which addresses some lints from the output of cargo clippy and also added my fix for the border updates 🚀

@LGUG2Z commented on GitHub (Nov 25, 2023): I was able to add a new origin to your fork and push it back here @thearturca https://github.com/LGUG2Z/komorebi/tree/animate-window-move I've rebased with the latest release, added a new commit on top which addresses some lints from the output of `cargo clippy` and also added my fix for the border updates 🚀
adam commented 2026-01-05 14:49:07 +01:00
Author
Owner
Copy Link

@thearturca commented on GitHub (Nov 25, 2023):

I was able to add a new origin to your fork and push it back here @thearturca

https://github.com/LGUG2Z/komorebi/tree/animate-window-move

I've rebased with the latest release, added a new commit on top which addresses some lints from the output of cargo clippy and also added my fix for the border updates 🚀

Wow amazing work!
Since you add new origin, do I need to make a PR?

@thearturca commented on GitHub (Nov 25, 2023): > I was able to add a new origin to your fork and push it back here @thearturca > > https://github.com/LGUG2Z/komorebi/tree/animate-window-move > > I've rebased with the latest release, added a new commit on top which addresses some lints from the output of `cargo clippy` and also added my fix for the border updates 🚀 Wow amazing work! Since you add new origin, do I need to make a PR?
adam commented 2026-01-05 14:49:07 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Nov 25, 2023):

Since you add new origin, do I need to make a PR?

Oops I forgot to open the PR; I'll do that now so that we can leave comments on code changes there!

@LGUG2Z commented on GitHub (Nov 25, 2023): > Since you add new origin, do I need to make a PR? Oops I forgot to open the PR; I'll do that now so that we can leave comments on code changes there!
adam commented 2026-01-05 14:49:07 +01:00
Author
Owner
Copy Link

@renhiyama commented on GitHub (Apr 27, 2024):

status report gif
This sounds interesting! Any status report?

@renhiyama commented on GitHub (Apr 27, 2024): ![status report gif](https://y.yarn.co/1e1ee6e3-df1f-43df-8504-72204d493531_text.gif) This sounds interesting! Any status report?
adam commented 2026-01-05 14:49:07 +01:00
Author
Owner
Copy Link

@FlyinCow commented on GitHub (Jul 24, 2024):

@thearturca #921 sir this way

@FlyinCow commented on GitHub (Jul 24, 2024): @thearturca #921 sir this way
adam commented 2026-01-05 14:49:07 +01:00
Author
Owner
Copy Link

@FlyinCow commented on GitHub (Jul 24, 2024):

meanwhile, any plans on workspace animation？

@FlyinCow commented on GitHub (Jul 24, 2024): meanwhile, any plans on workspace animation？
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#224
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?