mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-01-11 14:40:25 +01:00
[BUG]: shadow borders #189
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Kibouo on GitHub (Mar 19, 2023).
Some applications have shadow borders that cause komorebi colored borders to be misplaced. These shadow borders are also included in the window size when placing the windows. The clearest way of illustrating this is with a screenshot:
The windows shown here are:
The red border snugly fits on the vscode windows, while the red border on firefox is offset (offset can be seen in screenshot). Also firefox's tile is smaller due to this.
Other applications that behave similar to firefox:
Other applications that behave similar to vscode (correctly):
This is not related to Windows' universal window shadow settings (already tried turning that off).
identify-border-overflow-applicationalso didn't seem to help (maybe I'm using it wrong? I didkomorebic identify-border-overflow-application exe "firefox.exe").My border settings are as follows:
Host info:
@LGUG2Z commented on GitHub (Apr 16, 2023):
identify-border-overflow-applicationis generally (but not always!) used with Electron apps, because Electron apps generally try to draw over the invisible borders reserved by the operating system.The most common applications have generally been handled in this provided file.
In the case of Firefox and Windows Terminal, I don't think you should be using
identify-border-overflow-application, which is probably what is resulting in the behaviour you have shown.@Kibouo commented on GitHub (Apr 16, 2023):
Thank you for explaining what the option does.
However, the behavior is identical when not using the option.
From: جاد @.>
Sent: Sunday, April 16, 2023, 06:56
To: LGUG2Z/komorebi @.>
Cc: Kibouo @.>; Author @.>
Subject: Re: [LGUG2Z/komorebi] [BUG]: shadow borders (Issue #378)
identify-border-overflow-application is generally (but not always!) used with Electron apps, because Electron apps generally try to draw over the invisible borders reserved by the operating system.
The most common applications have generally been handled in this provided filehttps://github.com/LGUG2Z/komorebi/blob/master/komorebi.generated.ps1.
In the case of Firefox and Windows Terminal, I don't think you should be using identify-border-overflow-application, which is probably what is resulting in the behaviour you have shown.
—
Reply to this email directly, view it on GitHubhttps://github.com/LGUG2Z/komorebi/issues/378#issuecomment-1510058063, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGESTOKKVT5EBIU2QLKYCRLXBN3YNANCNFSM6AAAAAAWAEMFCM.
You are receiving this because you authored the thread.Message ID: @.***>
@LGUG2Z commented on GitHub (May 12, 2024):
I believe this is fixed as of
6a1ed3bcaa, if not before