starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[FEAT]: whitelist support to make windows unmanaged by default #163

New Issue
Closed
opened 2026-01-05 14:48:40 +01:00 by adam · 2 comments
adam commented 2026-01-05 14:48:40 +01:00
Owner
Copy Link

Originally created by @tsingakbar on GitHub (Nov 17, 2022).

Is your feature request related to a problem? Please describe.
For users not enthusiastic to dynamic tilling every window, to be able making windows unmanaged by default is really useful.

Describe the solution you'd like
Provide a toggle to make windows unmanaged by default, and the user can use manage-rule to whitelist the windows who needs to be dynamic tiled.

Additional context
I accomplished this somehow after digging into 57b1bc1414/komorebi/src/window.rs (L392) with autohotkey script like:

; make all window unmanaged unless whitelisted with rules
Run, komorebic.exe float-rule class "", , Hide
; for whitelisting see komorebi/src/window.rs: must use same property(class here) to override float-rule
; whitelist vscode
Run, komorebic.exe manage-rule class "Chrome_WidgetWin_1", , Hide
; whitelist firefox
Run, komorebic.exe manage-rule class "MozillaWindowClass", , Hide
; whitelist windows terminal
Run, komorebic.exe manage-rule class "CASCADIA_HOSTING_WINDOW_CLASS", , Hide
Originally created by @tsingakbar on GitHub (Nov 17, 2022). **Is your feature request related to a problem? Please describe.** For users not enthusiastic to dynamic tilling every window, to be able making windows unmanaged by default is really useful. **Describe the solution you'd like** Provide a toggle to make windows unmanaged by default, and the user can use `manage-rule` to whitelist the windows who needs to be dynamic tiled. **Additional context** I accomplished this somehow after digging into https://github.com/LGUG2Z/komorebi/blob/57b1bc1414bb6b339abc8167e50c30c49e2bbd06/komorebi/src/window.rs#L392 with autohotkey script like: ```autohotkey ; make all window unmanaged unless whitelisted with rules Run, komorebic.exe float-rule class "", , Hide ; for whitelisting see komorebi/src/window.rs: must use same property(class here) to override float-rule ; whitelist vscode Run, komorebic.exe manage-rule class "Chrome_WidgetWin_1", , Hide ; whitelist firefox Run, komorebic.exe manage-rule class "MozillaWindowClass", , Hide ; whitelist windows terminal Run, komorebic.exe manage-rule class "CASCADIA_HOSTING_WINDOW_CLASS", , Hide ```
adam added the enhancement label 2026-01-05 14:48:40 +01:00
adam closed this issue 2026-01-05 14:48:40 +01:00
adam commented 2026-01-05 14:48:40 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (Jan 22, 2023):

This is a very practical way to achieve the desired effect! I don't think this is something that I will work on personally since the solution you have provided seems quite flexible, but I will leave the issue open if anyone would like to work on this; I'll be happy to accept a PR.

@LGUG2Z commented on GitHub (Jan 22, 2023): This is a very practical way to achieve the desired effect! I don't think this is something that I will work on personally since the solution you have provided seems quite flexible, but I will leave the issue open if anyone would like to work on this; I'll be happy to accept a PR.
adam commented 2026-01-05 14:48:41 +01:00
Author
Owner
Copy Link

@LGUG2Z commented on GitHub (May 12, 2024):

Closing this out because upon reflection I don't think we'll be encouraging a whitelist approach

@LGUG2Z commented on GitHub (May 12, 2024): Closing this out because upon reflection I don't think we'll be encouraging a whitelist approach
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?