starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1590] [MERGED] fix: simplify stack-all command #1472

New Issue
Closed
opened 2026-01-05 14:55:24 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:55:24 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1590
Author: @alex-ds13
Created: 10/30/2025
Status: ✅ Merged
Merged: 10/30/2025
Merged by: @LGUG2Z

Base: master ← Head: fix/stack-all

📝 Commits (1)

  • 1ef5c56 fix: simplify stack-all command

📊 Changes

1 file changed (+19 additions, -10 deletions)

View changed files

📝 komorebi/src/window_manager.rs (+19 -10)

📄 Description

This commit makes the stack-all command simpler, by simply making a VecDeque with all the tiled windows of the workspace, then it creates a new container with that VecDeque and changes the workspace containers to be just this new container which has all the windows in it. Then and only then do we focus and show the previously focused window and hide all the rest.
This way we don't have a bunch of FocusChange/Cloak/Uncloak events coming up which might conflict with each other when the user has transparency and animations enabled. With this commit, there will only be one focus event for the focused window and one cloak event for each of the other windows.

Fixes #1490

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1590 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 10/30/2025 **Status:** ✅ Merged **Merged:** 10/30/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/stack-all` --- ### 📝 Commits (1) - [`1ef5c56`](https://github.com/LGUG2Z/komorebi/commit/1ef5c56ad3d05e453227b9ac8c68178ca22999b7) fix: simplify stack-all command ### 📊 Changes **1 file changed** (+19 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/window_manager.rs` (+19 -10) </details> ### 📄 Description This commit makes the `stack-all` command simpler, by simply making a `VecDeque` with all the tiled windows of the workspace, then it creates a new container with that `VecDeque` and changes the workspace containers to be just this new container which has all the windows in it. Then and only then do we focus and show the previously focused window and hide all the rest. This way we don't have a bunch of `FocusChange`/`Cloak`/`Uncloak` events coming up which might conflict with each other when the user has transparency and animations enabled. With this commit, there will only be one focus event for the focused window and one cloak event for each of the other windows. Fixes #1490 <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:55:24 +01:00
adam closed this issue 2026-01-05 14:55:24 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1472
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?