starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1524] feat(wm): add dynamic work area offsets #1445

New Issue
Open
opened 2026-01-05 14:55:18 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:55:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1524
Author: @omark96
Created: 8/2/2025
Status: 🔄 Open

Base: master ← Head: feat(wm)/dynamic-workspace-offset

📝 Commits (1)

  • 5f3a36d feat(wm): add dynamic work area offsets

📊 Changes

3 files changed (+41 additions, -2 deletions)

View changed files

📝 komorebi/src/static_config.rs (+11 -0)
📝 komorebi/src/window_manager.rs (+1 -0)
📝 komorebi/src/workspace.rs (+29 -2)

📄 Description

This commit adds a config setting to let you set custom work_area_offset_rules for a workspace, following a simlar schema as for layout_rules. Still WIP, I have yet to test it alongside https://github.com/LGUG2Z/komorebi/pull/1476 so awaiting the verdict on that before doing further testing.

Example of a workspace configured to use this:

{
  "name": "III",
  "layout": "BSP",
  "work_area_offset_rules": {
    "1": {
      "top": 100,
      "left": 400,
      "bottom": 200,
      "right": 800
    },
    "2": {
      "top": 0,
      "left": 200,
      "bottom": 0,
      "right": 400
    },
    "3": {
      "top": 0,
      "left": 0,
      "bottom": 0,
      "right": 0
    }
  }
}

EDIT: I just found that monocle mode is bugged and is using the rule for having 1 window less than what the workspace had before entering monocle mode. So if you have 2 windows open and go to monocle mode it will count as having 1 window open, but if you have 4 windows it will count as having 3 windows open. Will have to add special case for monocle mode.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1524 **Author:** [@omark96](https://github.com/omark96) **Created:** 8/2/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `feat(wm)/dynamic-workspace-offset` --- ### 📝 Commits (1) - [`5f3a36d`](https://github.com/LGUG2Z/komorebi/commit/5f3a36da32d0b145167463d2ca06a00517715f1b) feat(wm): add dynamic work area offsets ### 📊 Changes **3 files changed** (+41 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/static_config.rs` (+11 -0) 📝 `komorebi/src/window_manager.rs` (+1 -0) 📝 `komorebi/src/workspace.rs` (+29 -2) </details> ### 📄 Description This commit adds a config setting to let you set custom work_area_offset_rules for a workspace, following a simlar schema as for layout_rules. Still WIP, I have yet to test it alongside https://github.com/LGUG2Z/komorebi/pull/1476 so awaiting the verdict on that before doing further testing. Example of a workspace configured to use this: ```json { "name": "III", "layout": "BSP", "work_area_offset_rules": { "1": { "top": 100, "left": 400, "bottom": 200, "right": 800 }, "2": { "top": 0, "left": 200, "bottom": 0, "right": 400 }, "3": { "top": 0, "left": 0, "bottom": 0, "right": 0 } } } ``` EDIT: I just found that monocle mode is bugged and is using the rule for having 1 window less than what the workspace had before entering monocle mode. So if you have 2 windows open and go to monocle mode it will count as having 1 window open, but if you have 4 windows it will count as having 3 windows open. Will have to add special case for monocle mode. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:55:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1445
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?