starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1511] Multimonitor move to different monitor #1439

New Issue
Open
opened 2026-01-05 14:55:17 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:55:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1511
Author: @Gamsel
Created: 7/23/2025
Status: 🔄 Open

Base: master ← Head: MulitMonitorFocusSwitch

📝 Commits (1)

📊 Changes

1 file changed (+71 additions, -15 deletions)

View changed files

📝 komorebi/src/window_manager.rs (+71 -15)

📄 Description

Problem: If more than one monitor is eligible to move to, the behavior is undefined.

Solution: In WindowManager::monitor_idx_in_direction, added logic to handle multiple candidate monitors. When more than one monitor is found, the method now checks the top-left corner of the currently focused window to determine the appropriate monitor. If this check fails, it falls back to the first detected monitor.

P.S. This is my first time using Rust and contributing to a repository — please let me know if I’ve done anything incorrectly or if there’s anything I can improve! :)

image image image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1511 **Author:** [@Gamsel](https://github.com/Gamsel) **Created:** 7/23/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `MulitMonitorFocusSwitch` --- ### 📝 Commits (1) - [`7249309`](https://github.com/LGUG2Z/komorebi/commit/7249309773a6b36a5861b846f57a7b0e9d068e34) Baseline checkin ### 📊 Changes **1 file changed** (+71 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/window_manager.rs` (+71 -15) </details> ### 📄 Description Problem: If more than one monitor is eligible to move to, the behavior is undefined. Solution: In WindowManager::monitor_idx_in_direction, added logic to handle multiple candidate monitors. When more than one monitor is found, the method now checks the top-left corner of the currently focused window to determine the appropriate monitor. If this check fails, it falls back to the first detected monitor. P.S. This is my first time using Rust and contributing to a repository — please let me know if I’ve done anything incorrectly or if there’s anything I can improve! :) <img width="2092" height="1169" alt="image" src="https://github.com/user-attachments/assets/0297b551-76d7-46e6-8d94-7f0b13ae3535" /> <img width="2097" height="1185" alt="image" src="https://github.com/user-attachments/assets/2034a1c3-0305-48ca-9be8-6be76bd0af7c" /> <img width="1696" height="1098" alt="image" src="https://github.com/user-attachments/assets/6709bc1e-4d0c-4c53-b093-6f170e5992a8" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:55:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1439
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?