starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1500] refactor(ring): use MonitorIdx, WorkspaceIdx, ContainerIdx, WindowIdx instead of usize #1434

New Issue
Open
opened 2026-01-05 14:55:16 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:55:16 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1500
Author: @JustForFun88
Created: 7/10/2025
Status: 🔄 Open

Base: master ← Head: custom_index_for_each_ring_type

📝 Commits (8)

  • f9ea220 Stop exposing Ring internals
  • 862a55f Use Arc<str> and WsElementId instead of String
  • 3020684 make serialize and deserialize compact
  • 8cbf024 Make Window internals private.
  • 86b297f Make clippy happy
  • 67df67f Use MonitorIdx, WorkspaceIdx, ContainerIdx, WindowIdx instead of usize
  • f965aa9 contuniation
  • 88edc7d contuniation

📊 Changes

51 files changed (+2916 additions, -2404 deletions)

View changed files

📝 komorebi-bar/src/bar.rs (+20 -23)
📝 komorebi-bar/src/config.rs (+3 -2)
📝 komorebi-bar/src/main.rs (+15 -24)
📝 komorebi-bar/src/render.rs (+3 -2)
📝 komorebi-bar/src/widgets/battery.rs (+1 -1)
📝 komorebi-bar/src/widgets/cpu.rs (+3 -3)
📝 komorebi-bar/src/widgets/date.rs (+1 -1)
📝 komorebi-bar/src/widgets/komorebi.rs (+29 -24)
📝 komorebi-bar/src/widgets/komorebi_layout.rs (+8 -7)
📝 komorebi-bar/src/widgets/memory.rs (+3 -3)
📝 komorebi-bar/src/widgets/mod.rs (+5 -4)
📝 komorebi-bar/src/widgets/network.rs (+2 -2)
📝 komorebi-bar/src/widgets/storage.rs (+2 -2)
📝 komorebi-bar/src/widgets/time.rs (+1 -1)
📝 komorebi-bar/src/widgets/update.rs (+1 -1)
📝 komorebi-client/src/lib.rs (+6 -0)
📝 komorebi-gui/src/main.rs (+30 -27)
📝 komorebi/src/animation/prefix.rs (+1 -1)
📝 komorebi/src/border_manager/border.rs (+57 -39)
📝 komorebi/src/border_manager/mod.rs (+155 -131)

...and 31 more files

📄 Description

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1500 **Author:** [@JustForFun88](https://github.com/JustForFun88) **Created:** 7/10/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `custom_index_for_each_ring_type` --- ### 📝 Commits (8) - [`f9ea220`](https://github.com/LGUG2Z/komorebi/commit/f9ea220ccbeddc515279bcf5e6b8ee25a20ab9f2) Stop exposing Ring internals - [`862a55f`](https://github.com/LGUG2Z/komorebi/commit/862a55f06feca69a1d519b935427837e5f948905) Use `Arc<str>` and `WsElementId` instead of `String` - [`3020684`](https://github.com/LGUG2Z/komorebi/commit/3020684a16a143c18222e5cb39d460a6ab0c5af8) make serialize and deserialize compact - [`8cbf024`](https://github.com/LGUG2Z/komorebi/commit/8cbf0245cabcb1e920a175926959548f2b86c93d) Make `Window` internals private. - [`86b297f`](https://github.com/LGUG2Z/komorebi/commit/86b297f54b39fe80234568fc75d582d421890e0c) Make clippy happy - [`67df67f`](https://github.com/LGUG2Z/komorebi/commit/67df67f42f92864c617db05120c43b95657212d2) Use MonitorIdx, WorkspaceIdx, ContainerIdx, WindowIdx instead of usize - [`f965aa9`](https://github.com/LGUG2Z/komorebi/commit/f965aa9d64fb2070fafc12d6b638df3d620fe141) contuniation - [`88edc7d`](https://github.com/LGUG2Z/komorebi/commit/88edc7d9420e5fc3788ab21c56a22e4e57c19970) contuniation ### 📊 Changes **51 files changed** (+2916 additions, -2404 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/bar.rs` (+20 -23) 📝 `komorebi-bar/src/config.rs` (+3 -2) 📝 `komorebi-bar/src/main.rs` (+15 -24) 📝 `komorebi-bar/src/render.rs` (+3 -2) 📝 `komorebi-bar/src/widgets/battery.rs` (+1 -1) 📝 `komorebi-bar/src/widgets/cpu.rs` (+3 -3) 📝 `komorebi-bar/src/widgets/date.rs` (+1 -1) 📝 `komorebi-bar/src/widgets/komorebi.rs` (+29 -24) 📝 `komorebi-bar/src/widgets/komorebi_layout.rs` (+8 -7) 📝 `komorebi-bar/src/widgets/memory.rs` (+3 -3) 📝 `komorebi-bar/src/widgets/mod.rs` (+5 -4) 📝 `komorebi-bar/src/widgets/network.rs` (+2 -2) 📝 `komorebi-bar/src/widgets/storage.rs` (+2 -2) 📝 `komorebi-bar/src/widgets/time.rs` (+1 -1) 📝 `komorebi-bar/src/widgets/update.rs` (+1 -1) 📝 `komorebi-client/src/lib.rs` (+6 -0) 📝 `komorebi-gui/src/main.rs` (+30 -27) 📝 `komorebi/src/animation/prefix.rs` (+1 -1) 📝 `komorebi/src/border_manager/border.rs` (+57 -39) 📝 `komorebi/src/border_manager/mod.rs` (+155 -131) _...and 31 more files_ </details> ### 📄 Description <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:55:16 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1434
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?