starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1466] [MERGED] More window manager edge cases #1413

New Issue
Closed
opened 2026-01-05 14:55:12 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:55:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1466
Author: @SaucePackets
Created: 5/28/2025
Status: ✅ Merged
Merged: 8/19/2025
Merged by: @LGUG2Z

Base: master ← Head: more_window_manager_edge_cases

📝 Commits (6)

  • ecb31eb test(window_manager.rs): test removing nonexistent window from container
  • 5c568be test(window_manager.rs): test cycling windows in an empty container
  • bcd8002 test(window_manager.rs): test float nonexistent window
  • 67f465e test(window_manager.rs): test toggle maximize a nonexistent window
  • d7280d5 test(window_manager.rs): test toggle monocle on nonexistent container
  • 3499fe8 test(window_manager.rs): test monocle on and off on nonexistent container

📊 Changes

1 file changed (+208 additions, -0 deletions)

View changed files

📝 komorebi/src/window_manager.rs (+208 -0)

📄 Description

Created tests that tests removing nonexistent window, cycling windows in an empty container, and floating a nonexistent window.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1466 **Author:** [@SaucePackets](https://github.com/SaucePackets) **Created:** 5/28/2025 **Status:** ✅ Merged **Merged:** 8/19/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `more_window_manager_edge_cases` --- ### 📝 Commits (6) - [`ecb31eb`](https://github.com/LGUG2Z/komorebi/commit/ecb31ebab898fd485b3ca25f9d52f67d948e1975) test(window_manager.rs): test removing nonexistent window from container - [`5c568be`](https://github.com/LGUG2Z/komorebi/commit/5c568be31ddca0281ecdfed85f24fa2d74fdf41b) test(window_manager.rs): test cycling windows in an empty container - [`bcd8002`](https://github.com/LGUG2Z/komorebi/commit/bcd800242ac24edc39d7a369e26bffb5ea608f22) test(window_manager.rs): test float nonexistent window - [`67f465e`](https://github.com/LGUG2Z/komorebi/commit/67f465ed53e11a738d5898bc5e6005f1a49ce6f1) test(window_manager.rs): test toggle maximize a nonexistent window - [`d7280d5`](https://github.com/LGUG2Z/komorebi/commit/d7280d5394540bbf6e98cdbbd9ad6b3996cd9fe9) test(window_manager.rs): test toggle monocle on nonexistent container - [`3499fe8`](https://github.com/LGUG2Z/komorebi/commit/3499fe854244171643dedea6ebbe5974483f2620) test(window_manager.rs): test monocle on and off on nonexistent container ### 📊 Changes **1 file changed** (+208 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/window_manager.rs` (+208 -0) </details> ### 📄 Description <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> Created tests that tests removing nonexistent window, cycling windows in an empty container, and floating a nonexistent window. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:55:12 +01:00
adam closed this issue 2026-01-05 14:55:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1413
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?