starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1452] [MERGED] refactor(workspace): move locked into Container for bar refactor preparation #1407

New Issue
Closed
opened 2026-01-05 14:55:11 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:55:11 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1452
Author: @JustForFun88
Created: 5/18/2025
Status: ✅ Merged
Merged: 6/15/2025
Merged by: @LGUG2Z

Base: master ← Head: refactor_locked_container

📝 Commits (1)

  • 65696f9 Move locked property directly to the Container

📊 Changes

10 files changed (+462 additions, -381 deletions)

View changed files

📝 komorebi-bar/src/widgets/komorebi.rs (+5 -4)
📝 komorebi/src/border_manager/mod.rs (+2 -2)
📝 komorebi/src/container.rs (+56 -1)
📝 komorebi/src/lib.rs (+9 -1)
➕ komorebi/src/lockable_sequence.rs (+357 -0)
➖ komorebi/src/locked_deque.rs (+0 -316)
📝 komorebi/src/process_command.rs (+6 -2)
📝 komorebi/src/ring.rs (+0 -4)
📝 komorebi/src/window_manager.rs (+7 -11)
📝 komorebi/src/workspace.rs (+20 -40)

📄 Description

Key Changes

  • Added locked: bool field directly to the Container struct.
  • Removed locked_containers from Workspace.
  • Updated komorebi_bar to access locked directly from Container.

Motivation

This change prepares the simplification in the code in komorebi_bar, where tuple fields made it hard to understand what data represents. Investigation showed locked is an inherent property of a container, not a workspace-level concern.

As a result, the code is now cleaner and more readable in areas that deal with locked containers.

Tested

  • Not yet tested; will review behavior later. Works on Windows 11.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1452 **Author:** [@JustForFun88](https://github.com/JustForFun88) **Created:** 5/18/2025 **Status:** ✅ Merged **Merged:** 6/15/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `refactor_locked_container` --- ### 📝 Commits (1) - [`65696f9`](https://github.com/LGUG2Z/komorebi/commit/65696f9820da2b6e24ed928f02501514eb93ed66) Move `locked` property directly to the `Container` ### 📊 Changes **10 files changed** (+462 additions, -381 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/widgets/komorebi.rs` (+5 -4) 📝 `komorebi/src/border_manager/mod.rs` (+2 -2) 📝 `komorebi/src/container.rs` (+56 -1) 📝 `komorebi/src/lib.rs` (+9 -1) ➕ `komorebi/src/lockable_sequence.rs` (+357 -0) ➖ `komorebi/src/locked_deque.rs` (+0 -316) 📝 `komorebi/src/process_command.rs` (+6 -2) 📝 `komorebi/src/ring.rs` (+0 -4) 📝 `komorebi/src/window_manager.rs` (+7 -11) 📝 `komorebi/src/workspace.rs` (+20 -40) </details> ### 📄 Description ## Key Changes - Added `locked: bool` field directly to the `Container` struct. - Removed `locked_containers` from `Workspace`. - Updated `komorebi_bar` to access `locked` directly from `Container`. ## Motivation This change prepares the simplification in the code in `komorebi_bar`, where tuple fields made it hard to understand what data represents. Investigation showed `locked` is an inherent property of a container, not a workspace-level concern. As a result, the code is now cleaner and more readable in areas that deal with locked containers. ## Tested - ~Not yet tested; will review behavior later.~ Works on Windows 11. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:55:11 +01:00
adam closed this issue 2026-01-05 14:55:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1407
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?