starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1447] [MERGED] Window Manager Edge Case Tests #1405

New Issue
Closed
opened 2026-01-05 14:55:10 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:55:10 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1447
Author: @SaucePackets
Created: 5/16/2025
Status: ✅ Merged
Merged: 5/17/2025
Merged by: @LGUG2Z

Base: master ← Head: edge-case-tests

📝 Commits (3)

  • b7368c7 test(window_manager.rs): test swap workspace with nonexistent monitor
  • 58cdb00 test(window_manager.rs): test switch focus to nonexistent monitor
  • 2686b00 test(window_manager.rs): test swap container with non existent container

📊 Changes

1 file changed (+190 additions, -17 deletions)

View changed files

📝 komorebi/src/window_manager.rs (+190 -17)

📄 Description

Created tests to test switching focus to a nonexistent monitor, swapping a container with a nonexistent container, and swapping a workspace with a nonexistent monitor. PR also contains the bug fix @LGUG2Z fixed, where the container contents were deleted when attempting to swap a container with a nonexistent container. The fix ensures that both containers exist before removing the containers contents.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1447 **Author:** [@SaucePackets](https://github.com/SaucePackets) **Created:** 5/16/2025 **Status:** ✅ Merged **Merged:** 5/17/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `edge-case-tests` --- ### 📝 Commits (3) - [`b7368c7`](https://github.com/LGUG2Z/komorebi/commit/b7368c7a08f791a62e901d926074956427951eda) test(window_manager.rs): test swap workspace with nonexistent monitor - [`58cdb00`](https://github.com/LGUG2Z/komorebi/commit/58cdb00af89b9c3ce697ac5cf4e70e1e8638f0f4) test(window_manager.rs): test switch focus to nonexistent monitor - [`2686b00`](https://github.com/LGUG2Z/komorebi/commit/2686b00676aa76f60e1bff10cf7fb634a98887e0) test(window_manager.rs): test swap container with non existent container ### 📊 Changes **1 file changed** (+190 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/window_manager.rs` (+190 -17) </details> ### 📄 Description <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> Created tests to test switching focus to a nonexistent monitor, swapping a container with a nonexistent container, and swapping a workspace with a nonexistent monitor. PR also contains the bug fix @LGUG2Z fixed, where the container contents were deleted when attempting to swap a container with a nonexistent container. The fix ensures that both containers exist before removing the containers contents. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:55:10 +01:00
adam closed this issue 2026-01-05 14:55:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1405
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?