starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1427] [MERGED] Edge case tests for monitor, workspace, and window manager #1398

New Issue
Closed
opened 2026-01-05 14:55:09 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:55:09 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1427
Author: @SaucePackets
Created: 5/3/2025
Status: ✅ Merged
Merged: 5/10/2025
Merged by: @LGUG2Z

Base: master ← Head: edge-case-tests-monitor-and-workspace

📝 Commits (6)

  • 93570f5 test(monitor.rs): remove nonexistent workspace
  • aaf44c5 test(monitor.rs): test moving a container to a nonexistent workspace
  • 7225822 test(workspace.rs): test removing a non existent window
  • 8fa326b test(workspace.rs): move window to non existent container
  • 82ab2b9 test(window_manager.rs): test move workspace to non existent monitor
  • 122251c test(window_manager.rs): test transfer window to nonexistent monitor

📊 Changes

3 files changed (+200 additions, -1 deletions)

View changed files

📝 komorebi/src/monitor.rs (+59 -0)
📝 komorebi/src/window_manager.rs (+95 -1)
📝 komorebi/src/workspace.rs (+46 -0)

📄 Description

Created tests for testing removing a nonexistent workspace and window, moving a container to a workspace that hasn't been created, moving a workspace to a non existent monitor, and moving a window to a non existent container.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1427 **Author:** [@SaucePackets](https://github.com/SaucePackets) **Created:** 5/3/2025 **Status:** ✅ Merged **Merged:** 5/10/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `edge-case-tests-monitor-and-workspace` --- ### 📝 Commits (6) - [`93570f5`](https://github.com/LGUG2Z/komorebi/commit/93570f5acedc500832db0716a6ebfa673fb41059) test(monitor.rs): remove nonexistent workspace - [`aaf44c5`](https://github.com/LGUG2Z/komorebi/commit/aaf44c5eecadac0cd3aaf98013156ee063d3d797) test(monitor.rs): test moving a container to a nonexistent workspace - [`7225822`](https://github.com/LGUG2Z/komorebi/commit/7225822a19351d4d47bb4ce4dbb50d3941467113) test(workspace.rs): test removing a non existent window - [`8fa326b`](https://github.com/LGUG2Z/komorebi/commit/8fa326bcc17329b53ff4ad23bc3b55c239c634a2) test(workspace.rs): move window to non existent container - [`82ab2b9`](https://github.com/LGUG2Z/komorebi/commit/82ab2b99e60da77b99c2e294c6292da868230780) test(window_manager.rs): test move workspace to non existent monitor - [`122251c`](https://github.com/LGUG2Z/komorebi/commit/122251ca9e92cef3e271c710cb358d19d6b68227) test(window_manager.rs): test transfer window to nonexistent monitor ### 📊 Changes **3 files changed** (+200 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/monitor.rs` (+59 -0) 📝 `komorebi/src/window_manager.rs` (+95 -1) 📝 `komorebi/src/workspace.rs` (+46 -0) </details> ### 📄 Description <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> Created tests for testing removing a nonexistent workspace and window, moving a container to a workspace that hasn't been created, moving a workspace to a non existent monitor, and moving a window to a non existent container. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:55:09 +01:00
adam closed this issue 2026-01-05 14:55:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1398
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?