starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1368] [CLOSED] fix(wm): remove monitor duplicated serial numbers #1360

New Issue
Closed
opened 2026-01-05 14:55:01 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:55:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1368
Author: @alex-ds13
Created: 3/20/2025
Status: ❌ Closed

Base: master ← Head: fix/monitor-dupes

📝 Commits (1)

  • 8d552b0 fix(wm): remove monitor duplicated serial numbers

📊 Changes

2 files changed (+24 additions, -2 deletions)

View changed files

📝 komorebi/src/monitor_reconciliator/mod.rs (+12 -1)
📝 komorebi/src/windows_api.rs (+12 -1)

📄 Description

Apparently some monitors (:cough: Acer :cough:) show up with duplicated serial number ids. This would cause multiple issues. This commit adds a check to the monitors listing functions that checks if that monitor serial number id already exists and if it does, it removes the serial number id from the duplicated ones forcing them to use the device_id.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1368 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 3/20/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/monitor-dupes` --- ### 📝 Commits (1) - [`8d552b0`](https://github.com/LGUG2Z/komorebi/commit/8d552b0ad6bbcc00c92e2006af775b931e1a7c13) fix(wm): remove monitor duplicated serial numbers ### 📊 Changes **2 files changed** (+24 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/monitor_reconciliator/mod.rs` (+12 -1) 📝 `komorebi/src/windows_api.rs` (+12 -1) </details> ### 📄 Description Apparently some monitors (:cough: Acer :cough:) show up with duplicated serial number ids. This would cause multiple issues. This commit adds a check to the monitors listing functions that checks if that monitor serial number id already exists and if it does, it removes the serial number id from the duplicated ones forcing them to use the device_id. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:55:01 +01:00
adam closed this issue 2026-01-05 14:55:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1360
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?