starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1369] [MERGED] fix(wm): change when floating windows are centered #1359

New Issue
Closed
opened 2026-01-05 14:55:01 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:55:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1369
Author: @alex-ds13
Created: 3/20/2025
Status: ✅ Merged
Merged: 3/21/2025
Merged by: @LGUG2Z

Base: master ← Head: fix/center-floats

📝 Commits (1)

  • aa43aaf fix(wm): change when floating windows are centered

📊 Changes

1 file changed (+11 additions, -2 deletions)

View changed files

📝 komorebi/src/process_event.rs (+11 -2)

📄 Description

This commit changes the behaviour of when floating windows are centered by making them only center when we are on a WorkspaceLayer::Floating and the window doesn't match a floating_windows rule and the workspace is not a floating workspace.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1369 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 3/20/2025 **Status:** ✅ Merged **Merged:** 3/21/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/center-floats` --- ### 📝 Commits (1) - [`aa43aaf`](https://github.com/LGUG2Z/komorebi/commit/aa43aafd7080134485e5df2da4287c57885b1107) fix(wm): change when floating windows are centered ### 📊 Changes **1 file changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/process_event.rs` (+11 -2) </details> ### 📄 Description This commit changes the behaviour of when floating windows are centered by making them only center when we are on a `WorkspaceLayer::Floating` and the window doesn't match a `floating_windows` rule and the workspace is not a floating workspace. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:55:01 +01:00
adam closed this issue 2026-01-05 14:55:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1359
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?