starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1361] [MERGED] fix: forced float-override on Floating layer without overwriting user config #1352

New Issue
Closed
opened 2026-01-05 14:54:59 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:59 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1361
Author: @alex-ds13
Created: 3/17/2025
Status: ✅ Merged
Merged: 3/18/2025
Merged by: @LGUG2Z

Base: master ← Head: fix/float-override

📝 Commits (2)

  • 0736a41 Revert "feat(wm): toggle float override with floating layer"
  • 2e04d25 feat(wm): toggle float override with floating layer

📊 Changes

2 files changed (+7 additions, -15 deletions)

View changed files

📝 komorebi/src/window_manager.rs (+6 -1)
📝 komorebi/src/workspace.rs (+1 -14)

📄 Description

As mentioned on Discord this PR reverts the previous commit that turned on the float_override when switching to the Floating layer and turned it off when switching to the Tiling layer since this would result in an overwrite of the user config.

This PR uses a different method to accomplish the same behaviour without overwriting the user's config. It changes the window_management_behaviour() function to check the behaviour for the workspace in question and then it checks if the workspace has the float_override set or if the workspace layer is Floating.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1361 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 3/17/2025 **Status:** ✅ Merged **Merged:** 3/18/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/float-override` --- ### 📝 Commits (2) - [`0736a41`](https://github.com/LGUG2Z/komorebi/commit/0736a41eea6b22db26e3227d87965f610b879d57) Revert "feat(wm): toggle float override with floating layer" - [`2e04d25`](https://github.com/LGUG2Z/komorebi/commit/2e04d25a719fac40af7ded8f1b7481cf91ea52d8) feat(wm): toggle float override with floating layer ### 📊 Changes **2 files changed** (+7 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/window_manager.rs` (+6 -1) 📝 `komorebi/src/workspace.rs` (+1 -14) </details> ### 📄 Description As mentioned on Discord this PR reverts the previous commit that turned on the `float_override` when switching to the `Floating` layer and turned it off when switching to the `Tiling` layer since this would result in an overwrite of the user config. This PR uses a different method to accomplish the same behaviour without overwriting the user's config. It changes the `window_management_behaviour()` function to check the behaviour for the workspace in question and then it checks if the workspace has the `float_override` set or if the workspace layer is `Floating`. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:59 +01:00
adam closed this issue 2026-01-05 14:54:59 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1352
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?