starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1356] [MERGED] fix(wm): fix bugs on workspace restore and remove workarounds #1347

New Issue
Closed
opened 2026-01-05 14:54:58 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:58 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1356
Author: @alex-ds13
Created: 3/17/2025
Status: ✅ Merged
Merged: 3/18/2025
Merged by: @LGUG2Z

Base: master ← Head: fix/workspace-restore

📝 Commits (1)

  • 20055ad fix(wm): fix bugs on workspace restore and remove workarounds

📊 Changes

2 files changed (+7 additions, -21 deletions)

View changed files

📝 komorebi/src/window_manager.rs (+0 -20)
📝 komorebi/src/workspace.rs (+7 -1)

📄 Description

This commit removes some workarounds on the update_focused_workspace function that were there to fix issues related to some bugs on the workspace.restore() function. This commit fixes the bugs on the restore function instead. The update_focused_workspace function should be used only to update a workspace layout.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1356 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 3/17/2025 **Status:** ✅ Merged **Merged:** 3/18/2025 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/workspace-restore` --- ### 📝 Commits (1) - [`20055ad`](https://github.com/LGUG2Z/komorebi/commit/20055ad6f36ca769252078165c9184f93e080e60) fix(wm): fix bugs on workspace restore and remove workarounds ### 📊 Changes **2 files changed** (+7 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/window_manager.rs` (+0 -20) 📝 `komorebi/src/workspace.rs` (+7 -1) </details> ### 📄 Description This commit removes some workarounds on the `update_focused_workspace` function that were there to fix issues related to some bugs on the `workspace.restore()` function. This commit fixes the bugs on the `restore` function instead. The `update_focused_workspace` function should be used only to update a workspace layout. <!-- Please follow the Conventional Commits specification. If you need to update your PR with changes from `master`, please run `git rebase master`. By opening this PR, you confirm that you have read and understood this project's `CONTRIBUTING.md`. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:58 +01:00
adam closed this issue 2026-01-05 14:54:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?